Skip to content

[improve](iceberg rest) Add a default network connection timeout to Iceberg REST #58395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
CalvinKirs merged 1 commit into from
Nov 27, 2025
Merged

[improve](iceberg rest) Add a default network connection timeout to Iceberg REST #58395

CalvinKirs merged 1 commit into from
Nov 27, 2025

Conversation

@zy-kkk
Copy link
Member

@zy-kkk zy-kkk commented Nov 26, 2025

When the network connection to the Iceberg REST server is unavailable, the lack of a timeout setting can lead to excessively long waiting times. Therefore, a slightly shorter default timeout has been added, and users can also set their own timeout.

@hello-stephen
Copy link
Contributor

hello-stephen commented Nov 26, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@zy-kkk
Copy link
Member Author

zy-kkk commented Nov 26, 2025

run buildall

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Nov 26, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Nov 26, 2025

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 26, 2025

PR approved by anyone and no changes requested.

@doris-robot
Copy link

doris-robot commented Nov 26, 2025

TPC-H: Total hot run time: 34434 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 57c45a8a1d7cbb2f2d2a48c21d6c3f750a4bb41c, data reload: false

------ Round 1 ----------------------------------
q1	17599	5115	4943	4943
q2	2030	317	224	224
q3	10229	1306	745	745
q4	10241	946	369	369
q5	7564	2452	2261	2261
q6	189	175	144	144
q7	974	775	664	664
q8	9369	1323	1131	1131
q9	7360	5350	5383	5350
q10	6907	2261	1797	1797
q11	491	288	287	287
q12	354	359	219	219
q13	17766	3664	3029	3029
q14	246	253	215	215
q15	585	531	515	515
q16	1018	1011	966	966
q17	603	879	356	356
q18	7824	7294	7186	7186
q19	1097	955	552	552
q20	358	351	230	230
q21	3957	3215	2295	2295
q22	1019	1010	956	956
Total cold run time: 107780 ms
Total hot run time: 34434 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4979	4955	4933	4933
q2	337	398	314	314
q3	2209	2735	2316	2316
q4	1387	1778	1362	1362
q5	4272	4583	4471	4471
q6	222	175	139	139
q7	1997	2049	1784	1784
q8	2774	2618	2603	2603
q9	7721	7538	7645	7538
q10	3060	3282	2807	2807
q11	596	517	498	498
q12	693	774	588	588
q13	3659	3897	3317	3317
q14	294	307	274	274
q15	560	509	513	509
q16	1266	1158	1092	1092
q17	1170	1600	1337	1337
q18	7918	7644	7630	7630
q19	811	835	978	835
q20	2087	2098	2065	2065
q21	4860	4374	4298	4298
q22	1070	1055	1007	1007
Total cold run time: 53942 ms
Total hot run time: 51717 ms

@doris-robot
Copy link

doris-robot commented Nov 26, 2025

TPC-DS: Total hot run time: 183946 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 57c45a8a1d7cbb2f2d2a48c21d6c3f750a4bb41c, data reload: false

query1	1047	437	390	390
query2	6572	1635	1576	1576
query3	6782	229	223	223
query4	25588	23031	22689	22689
query5	4429	653	493	493
query6	338	240	216	216
query7	4659	499	296	296
query8	291	249	240	240
query9	8697	2602	2587	2587
query10	537	365	303	303
query11	15416	14884	14571	14571
query12	184	115	113	113
query13	1681	602	463	463
query14	10930	8942	9002	8942
query15	232	207	190	190
query16	7467	692	531	531
query17	1274	805	641	641
query18	2034	444	346	346
query19	223	211	183	183
query20	132	125	122	122
query21	217	135	118	118
query22	3791	3940	3795	3795
query23	33131	32094	32183	32094
query24	8510	2411	2406	2406
query25	645	554	480	480
query26	1251	279	172	172
query27	2741	502	356	356
query28	4412	2187	2100	2100
query29	810	653	491	491
query30	316	233	207	207
query31	878	717	606	606
query32	77	72	69	69
query33	591	388	315	315
query34	803	872	522	522
query35	788	831	724	724
query36	894	971	839	839
query37	121	104	82	82
query38	3355	3346	3254	3254
query39	1490	1441	1408	1408
query40	223	128	118	118
query41	65	66	64	64
query42	129	113	112	112
query43	440	471	434	434
query44	1237	764	762	762
query45	200	197	185	185
query46	883	996	636	636
query47	1686	1724	1664	1664
query48	394	431	340	340
query49	779	509	389	389
query50	670	686	417	417
query51	3978	3834	3962	3834
query52	111	112	107	107
query53	240	260	186	186
query54	311	300	312	300
query55	95	88	90	88
query56	323	315	315	315
query57	1155	1175	1113	1113
query58	292	294	268	268
query59	2378	2551	2411	2411
query60	346	350	340	340
query61	165	162	163	162
query62	782	702	649	649
query63	230	187	191	187
query64	4545	1193	915	915
query65	4048	3965	4003	3965
query66	1140	450	324	324
query67	15146	15017	14663	14663
query68	8246	987	644	644
query69	519	337	308	308
query70	1315	1225	1263	1225
query71	445	326	304	304
query72	6077	4937	4911	4911
query73	665	609	348	348
query74	9040	8503	8581	8503
query75	3790	3323	2789	2789
query76	3512	1128	709	709
query77	800	397	325	325
query78	9515	9521	8777	8777
query79	2253	837	611	611
query80	639	567	492	492
query81	524	267	234	234
query82	475	166	128	128
query83	269	262	253	253
query84	257	113	100	100
query85	960	486	449	449
query86	386	314	297	297
query87	3535	3618	3456	3456
query88	3730	2258	2256	2256
query89	386	317	293	293
query90	1915	223	220	220
query91	170	172	145	145
query92	82	68	66	66
query93	1849	994	666	666
query94	749	461	353	353
query95	503	407	393	393
query96	503	591	275	275
query97	2996	2943	2841	2841
query98	234	215	207	207
query99	1528	1365	1267	1267
Total cold run time: 273192 ms
Total hot run time: 183946 ms

@doris-robot
Copy link

doris-robot commented Nov 26, 2025

ClickBench: Total hot run time: 27.77 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 57c45a8a1d7cbb2f2d2a48c21d6c3f750a4bb41c, data reload: false

query1	0.06	0.04	0.04
query2	0.09	0.05	0.05
query3	0.25	0.09	0.08
query4	1.61	0.12	0.11
query5	0.26	0.26	0.25
query6	1.20	0.66	0.63
query7	0.03	0.02	0.02
query8	0.06	0.04	0.04
query9	0.58	0.51	0.52
query10	0.58	0.57	0.57
query11	0.17	0.11	0.12
query12	0.15	0.12	0.12
query13	0.63	0.61	0.60
query14	1.00	0.99	0.99
query15	0.85	0.83	0.84
query16	0.38	0.40	0.41
query17	1.02	1.02	1.02
query18	0.21	0.20	0.19
query19	1.91	1.80	1.84
query20	0.02	0.02	0.02
query21	15.45	0.18	0.12
query22	5.08	0.07	0.05
query23	15.66	0.26	0.10
query24	2.75	0.81	0.88
query25	0.07	0.07	0.06
query26	0.15	0.13	0.13
query27	0.07	0.05	0.05
query28	5.26	1.13	0.92
query29	12.57	3.92	3.24
query30	0.30	0.15	0.12
query31	2.82	0.60	0.40
query32	3.24	0.55	0.47
query33	3.11	2.99	3.01
query34	15.78	5.20	4.54
query35	4.57	4.53	4.52
query36	0.69	0.51	0.50
query37	0.10	0.07	0.07
query38	0.06	0.04	0.04
query39	0.04	0.03	0.03
query40	0.18	0.14	0.14
query41	0.09	0.04	0.03
query42	0.04	0.03	0.03
query43	0.05	0.04	0.03
Total cold run time: 99.19 s
Total hot run time: 27.77 s

@hello-stephen
Copy link
Contributor

hello-stephen commented Nov 26, 2025

FE Regression Coverage Report

Increment line coverage 66.67% (4/6) 🎉
Increment coverage report
Complete coverage report

@CalvinKirs CalvinKirs merged commit b8bdbd4 into apache:master Nov 27, 2025
30 of 31 checks passed
github-actions bot pushed a commit that referenced this pull request Nov 27, 2025
@zy-kkk
[improve](iceberg rest) Add a default network connection timeout to I…
3ebf686 
…ceberg REST (#58395)

When the network connection to the Iceberg REST server is unavailable,
the lack of a timeout setting can lead to excessively long waiting
times. Therefore, a slightly shorter default timeout has been added, and
users can also set their own timeout.
@github-actions github-actions bot mentioned this pull request Nov 27, 2025
Merged
github-actions bot pushed a commit that referenced this pull request Nov 27, 2025
@zy-kkk
[improve](iceberg rest) Add a default network connection timeout to I…
81c2d16 
…ceberg REST (#58395)

When the network connection to the Iceberg REST server is unavailable,
the lack of a timeout setting can lead to excessively long waiting
times. Therefore, a slightly shorter default timeout has been added, and
users can also set their own timeout.
@github-actions github-actions bot mentioned this pull request Nov 27, 2025
Merged
@zy-kkk zy-kkk deleted the iceberg_rest_time_out branch November 27, 2025 02:52
yiguolei pushed a commit that referenced this pull request Nov 28, 2025
@github-actions @zy-kkk
branch-4.0: [improve](iceberg rest) Add a default network connection …
e967e78 
…timeout to Iceberg REST #58395 (#58436)

Cherry-picked from #58395

Co-authored-by: zy-kkk <zhongyk10@gmail.com>
morrySnow pushed a commit that referenced this pull request Dec 1, 2025
@github-actions @zy-kkk
branch-3.1: [improve](iceberg rest) Add a default network connection …
9fcc397 
…timeout to Iceberg REST #58395 (#58434)

Cherry-picked from #58395

Co-authored-by: zy-kkk <zhongyk10@gmail.com>
nagisa-kunhah pushed a commit to nagisa-kunhah/doris that referenced this pull request Dec 14, 2025
@zy-kkk @nagisa-kunhah
[improve](iceberg rest) Add a default network connection timeout to I…
72ec578 
…ceberg REST (apache#58395)

When the network connection to the Iceberg REST server is unavailable,
the lack of a timeout setting can lead to excessively long waiting
times. Therefore, a slightly shorter default timeout has been added, and
users can also set their own timeout.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@morningman morningman morningman approved these changes

@CalvinKirs CalvinKirs CalvinKirs approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. dev/3.1.4-merged dev/4.0.2-merged reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@zy-kkk @hello-stephen @doris-robot @morningman @CalvinKirs @yiguolei @morrySnow