Skip to content

[improve](iceberg rest) Use catalog.listNamespaces(); to test connectivity to cover more properties. #58408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
CalvinKirs merged 1 commit into from
Nov 27, 2025
Merged

[improve](iceberg rest) Use catalog.listNamespaces(); to test connectivity to cover more properties. #58408

CalvinKirs merged 1 commit into from
Nov 27, 2025

Conversation

@zy-kkk
Copy link
Member

@zy-kkk zy-kkk commented Nov 26, 2025

1、Use catalog.listNamespaces(); to test connectivity to cover more properties; such as warehouse
2、Enrich error message

@hello-stephen
Copy link
Contributor

hello-stephen commented Nov 26, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@zy-kkk
Copy link
Member Author

zy-kkk commented Nov 26, 2025

run buildall

@doris-robot
Copy link

doris-robot commented Nov 26, 2025

TPC-H: Total hot run time: 34379 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 34d0811cd8fe689368a469ae7ee87f9687931ef1, data reload: false

------ Round 1 ----------------------------------
q1	17592	5132	4938	4938
q2	2065	339	219	219
q3	10184	1309	734	734
q4	10223	848	363	363
q5	7452	2325	2306	2306
q6	184	175	145	145
q7	951	810	643	643
q8	9358	1339	1184	1184
q9	7094	5290	5304	5290
q10	6884	2231	1803	1803
q11	499	305	288	288
q12	351	366	226	226
q13	17775	3662	3051	3051
q14	229	235	217	217
q15	595	509	513	509
q16	1046	1007	959	959
q17	605	866	355	355
q18	7336	7063	7043	7043
q19	1351	942	579	579
q20	357	367	231	231
q21	4054	3238	2343	2343
q22	1046	1007	953	953
Total cold run time: 107231 ms
Total hot run time: 34379 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5023	4958	4923	4923
q2	327	402	310	310
q3	2211	2707	2298	2298
q4	1462	1813	1301	1301
q5	4237	4432	4645	4432
q6	213	172	131	131
q7	2001	2054	1874	1874
q8	2698	2725	2649	2649
q9	7503	7377	7565	7377
q10	3042	3224	2887	2887
q11	586	548	508	508
q12	733	808	636	636
q13	3635	3836	3343	3343
q14	310	311	272	272
q15	565	509	507	507
q16	1093	1135	1097	1097
q17	1185	1594	1387	1387
q18	7867	7965	7537	7537
q19	842	893	935	893
q20	2038	2058	1803	1803
q21	4783	4250	4219	4219
q22	1095	1080	998	998
Total cold run time: 53449 ms
Total hot run time: 51382 ms

@doris-robot
Copy link

doris-robot commented Nov 26, 2025

TPC-DS: Total hot run time: 184160 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 34d0811cd8fe689368a469ae7ee87f9687931ef1, data reload: false

query1	1093	395	391	391
query2	6551	1573	1569	1569
query3	6754	226	222	222
query4	25674	22622	22338	22338
query5	4459	659	481	481
query6	348	232	232	232
query7	4646	506	319	319
query8	312	256	243	243
query9	8686	2550	2577	2550
query10	542	359	312	312
query11	15283	14822	14662	14662
query12	181	119	117	117
query13	1708	585	460	460
query14	10301	9131	8991	8991
query15	214	208	187	187
query16	7668	686	561	561
query17	1272	773	655	655
query18	2039	449	343	343
query19	216	211	183	183
query20	133	126	129	126
query21	220	136	121	121
query22	3932	3922	3761	3761
query23	32958	32147	32058	32058
query24	8537	2403	2386	2386
query25	584	511	447	447
query26	1231	279	162	162
query27	2755	499	337	337
query28	4337	2121	2115	2115
query29	805	613	488	488
query30	313	252	216	216
query31	840	729	627	627
query32	86	73	71	71
query33	584	390	343	343
query34	813	870	538	538
query35	791	835	748	748
query36	920	962	907	907
query37	119	117	92	92
query38	3384	3384	3305	3305
query39	1470	1414	1395	1395
query40	226	129	121	121
query41	66	64	63	63
query42	130	111	119	111
query43	468	460	443	443
query44	1285	768	758	758
query45	201	199	186	186
query46	898	987	625	625
query47	1716	1708	1649	1649
query48	395	429	329	329
query49	804	522	414	414
query50	679	683	414	414
query51	3853	3999	3869	3869
query52	110	114	117	114
query53	232	275	191	191
query54	351	301	286	286
query55	95	96	93	93
query56	334	323	336	323
query57	1155	1168	1100	1100
query58	287	281	267	267
query59	2409	2479	2419	2419
query60	353	349	352	349
query61	167	159	160	159
query62	790	723	674	674
query63	228	195	198	195
query64	4565	1247	927	927
query65	4060	3983	3973	3973
query66	1135	447	327	327
query67	15267	14886	14651	14651
query68	8301	902	629	629
query69	534	350	301	301
query70	1299	1265	1162	1162
query71	424	336	297	297
query72	5905	4951	4949	4949
query73	666	622	358	358
query74	8582	8874	8502	8502
query75	3315	3374	2845	2845
query76	3303	1134	731	731
query77	529	406	320	320
query78	9379	9585	8910	8910
query79	2027	841	588	588
query80	630	586	514	514
query81	493	273	237	237
query82	208	163	136	136
query83	267	269	256	256
query84	261	110	103	103
query85	899	492	440	440
query86	337	283	291	283
query87	3568	3554	3421	3421
query88	3604	2283	2296	2283
query89	398	347	290	290
query90	2035	235	220	220
query91	179	168	139	139
query92	85	69	65	65
query93	1671	1020	666	666
query94	749	463	341	341
query95	500	411	402	402
query96	500	591	289	289
query97	2888	2975	2849	2849
query98	245	213	211	211
query99	1317	1374	1334	1334
Total cold run time: 270116 ms
Total hot run time: 184160 ms

@doris-robot
Copy link

doris-robot commented Nov 26, 2025

ClickBench: Total hot run time: 27.46 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 34d0811cd8fe689368a469ae7ee87f9687931ef1, data reload: false

query1	0.06	0.05	0.05
query2	0.10	0.04	0.04
query3	0.25	0.08	0.09
query4	1.61	0.11	0.11
query5	0.26	0.25	0.24
query6	1.17	0.65	0.64
query7	0.03	0.03	0.03
query8	0.06	0.05	0.04
query9	0.59	0.52	0.52
query10	0.56	0.56	0.58
query11	0.16	0.12	0.11
query12	0.15	0.12	0.11
query13	0.62	0.61	0.60
query14	1.01	1.01	1.00
query15	0.85	0.83	0.82
query16	0.40	0.39	0.38
query17	1.00	1.05	1.00
query18	0.21	0.21	0.20
query19	1.88	1.82	1.76
query20	0.01	0.01	0.02
query21	15.41	0.20	0.13
query22	5.14	0.07	0.05
query23	15.70	0.26	0.10
query24	2.10	0.49	0.70
query25	0.09	0.06	0.06
query26	0.15	0.14	0.13
query27	0.08	0.10	0.05
query28	4.87	1.12	0.93
query29	12.61	3.93	3.20
query30	0.29	0.13	0.12
query31	2.82	0.59	0.39
query32	3.23	0.56	0.48
query33	2.97	3.04	3.09
query34	15.82	5.18	4.58
query35	4.57	4.59	4.57
query36	0.70	0.50	0.49
query37	0.10	0.07	0.06
query38	0.07	0.04	0.04
query39	0.04	0.02	0.02
query40	0.17	0.14	0.14
query41	0.08	0.04	0.03
query42	0.04	0.03	0.04
query43	0.04	0.03	0.04
Total cold run time: 98.07 s
Total hot run time: 27.46 s

@hello-stephen
Copy link
Contributor

hello-stephen commented Nov 26, 2025

FE Regression Coverage Report

Increment line coverage 100.00% (2/2) 🎉
Increment coverage report
Complete coverage report

morningman
morningman approved these changes Nov 27, 2025
View reviewed changes
Copy link
Contributor

@morningman morningman left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Nov 27, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Nov 27, 2025

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 27, 2025

PR approved by anyone and no changes requested.

@CalvinKirs CalvinKirs merged commit bdcaede into apache:master Nov 27, 2025
31 of 32 checks passed
github-actions bot pushed a commit that referenced this pull request Nov 27, 2025
@zy-kkk
[improve](iceberg rest) Use catalog.listNamespaces(); to test conne…
142fd44 
…ctivity to cover more properties. (#58408)

1、Use `catalog.listNamespaces();` to test connectivity to cover more
properties; such as `warehouse`
2、Enrich error message
@github-actions github-actions bot mentioned this pull request Nov 27, 2025
Merged
github-actions bot pushed a commit that referenced this pull request Nov 27, 2025
@zy-kkk
[improve](iceberg rest) Use catalog.listNamespaces(); to test conne…
ed038dd 
…ctivity to cover more properties. (#58408)

1、Use `catalog.listNamespaces();` to test connectivity to cover more
properties; such as `warehouse`
2、Enrich error message
@github-actions github-actions bot mentioned this pull request Nov 27, 2025
Merged
yiguolei pushed a commit that referenced this pull request Nov 27, 2025
@github-actions @zy-kkk
branch-4.0: [improve](iceberg rest) Use catalog.listNamespaces(); t…
1dc0bb1 
…o test connectivity to cover more properties. #58408 (#58435)

Cherry-picked from #58408

Co-authored-by: zy-kkk <zhongyk10@gmail.com>
morrySnow pushed a commit that referenced this pull request Dec 2, 2025
@github-actions @zy-kkk
branch-3.1: [improve](iceberg rest) Use catalog.listNamespaces(); t…
f2d2804 
…o test connectivity to cover more properties. #58408 (#58433)

Cherry-picked from #58408

Co-authored-by: zy-kkk <zhongyk10@gmail.com>
nagisa-kunhah pushed a commit to nagisa-kunhah/doris that referenced this pull request Dec 14, 2025
@zy-kkk @nagisa-kunhah
[improve](iceberg rest) Use catalog.listNamespaces(); to test conne…
635e758 
…ctivity to cover more properties. (apache#58408)

1、Use `catalog.listNamespaces();` to test connectivity to cover more
properties; such as `warehouse`
2、Enrich error message
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@morningman morningman morningman approved these changes

@CalvinKirs CalvinKirs CalvinKirs approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. dev/3.1.4-merged dev/4.0.2-merged reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@zy-kkk @hello-stephen @doris-robot @morningman @CalvinKirs @yiguolei @morrySnow