-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[fix](mv) Fix stats unknown when calc sync mv plan statistics #58426
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix](mv) Fix stats unknown when calc sync mv plan statistics #58426
Conversation
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
|
run buildall |
a7000d4 to
68d17f0
Compare
|
run buildall |
TPC-H: Total hot run time: 34211 ms |
TPC-DS: Total hot run time: 183979 ms |
ClickBench: Total hot run time: 27.36 s |
FE UT Coverage ReportIncrement line coverage |
FE Regression Coverage ReportIncrement line coverage |
68d17f0 to
b1d8aa0
Compare
|
run buildall |
TPC-H: Total hot run time: 35496 ms |
TPC-DS: Total hot run time: 181560 ms |
ClickBench: Total hot run time: 27.29 s |
FE UT Coverage ReportIncrement line coverage |
|
run buildall |
TPC-H: Total hot run time: 34362 ms |
TPC-DS: Total hot run time: 181556 ms |
ClickBench: Total hot run time: 27.15 s |
FE Regression Coverage ReportIncrement line coverage |
2 similar comments
FE Regression Coverage ReportIncrement line coverage |
FE Regression Coverage ReportIncrement line coverage |
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
### What problem does this PR solve? Related PR: #36760 #57850 Problem Summary: Fix stats unknown when calc sync mv plan statistics For SQLs that are related to statistics, we should not collect or compute statistics. Previously this was determined by the `isInternal` flag, but `isInternal` is too broad: it covers not only statistics-related SQL but also SQL used to generate materialized view plans. Materialized view plan generation requires statistics, so we introduce a new flag `isPlanWithUnKnownColumnStats` to indicate connections that are used for statistics-only operations (treat column statistics as unknown).
…#58426) Related PR: Problem Summary: Fix stats unknown when calc sync mv plan statistics For SQLs that are related to statistics, we should not collect or compute statistics. Previously this was determined by the `isInternal` flag, but `isInternal` is too broad: it covers not only statistics-related SQL but also SQL used to generate materialized view plans. Materialized view plan generation requires statistics, so we introduce a new flag `isPlanWithUnKnownColumnStats` to indicate connections that are used for statistics-only operations (treat column statistics as unknown).
### What problem does this PR solve? Related PR: #36760 #57850 Problem Summary: Fix stats unknown when calc sync mv plan statistics For SQLs that are related to statistics, we should not collect or compute statistics. Previously this was determined by the `isInternal` flag, but `isInternal` is too broad: it covers not only statistics-related SQL but also SQL used to generate materialized view plans. Materialized view plan generation requires statistics, so we introduce a new flag `isPlanWithUnKnownColumnStats` to indicate connections that are used for statistics-only operations (treat column statistics as unknown).
…#58426) ### What problem does this PR solve? Related PR: apache#36760 apache#57850 Problem Summary: Fix stats unknown when calc sync mv plan statistics For SQLs that are related to statistics, we should not collect or compute statistics. Previously this was determined by the `isInternal` flag, but `isInternal` is too broad: it covers not only statistics-related SQL but also SQL used to generate materialized view plans. Materialized view plan generation requires statistics, so we introduce a new flag `isPlanWithUnKnownColumnStats` to indicate connections that are used for statistics-only operations (treat column statistics as unknown).
### What problem does this PR solve? Related PR: #36760 #57850 Problem Summary: Fix stats unknown when calc sync mv plan statistics For SQLs that are related to statistics, we should not collect or compute statistics. Previously this was determined by the `isInternal` flag, but `isInternal` is too broad: it covers not only statistics-related SQL but also SQL used to generate materialized view plans. Materialized view plan generation requires statistics, so we introduce a new flag `isPlanWithUnKnownColumnStats` to indicate connections that are used for statistics-only operations (treat column statistics as unknown).
…#58426) ### What problem does this PR solve? Related PR: apache#36760 apache#57850 Problem Summary: Fix stats unknown when calc sync mv plan statistics For SQLs that are related to statistics, we should not collect or compute statistics. Previously this was determined by the `isInternal` flag, but `isInternal` is too broad: it covers not only statistics-related SQL but also SQL used to generate materialized view plans. Materialized view plan generation requires statistics, so we introduce a new flag `isPlanWithUnKnownColumnStats` to indicate connections that are used for statistics-only operations (treat column statistics as unknown).
What problem does this PR solve?
Fix stats unknown when calc sync mv plan statistics
For SQLs that are related to statistics, we should not collect or compute statistics. Previously this was determined by the
isInternalflag, butisInternalis too broad: it covers not only statistics-related SQL but also SQL used to generate materialized view plans. Materialized view plan generation requires statistics, so we introduce a new flagisPlanWithUnKnownColumnStatsto indicate connections that are used for statistics-only operations (treat column statistics as unknown).Issue Number: close #xxx
Related PR:
#36760
#57850
Problem Summary:
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)