Skip to content

branch-3.1: [improve](iceberg rest) Use catalog.listNamespaces(); to test connectivity to cover more properties. #58408 #58433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
morrySnow merged 1 commit into from
Dec 2, 2025
Merged

branch-3.1: [improve](iceberg rest) Use catalog.listNamespaces(); to test connectivity to cover more properties. #58408 #58433

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions ...src/main/java/org/apache/doris/datasource/connectivity/IcebergRestConnectivityTester.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
import org.apache.doris.datasource.property.metastore.IcebergRestProperties;

import org.apache.iceberg.CatalogProperties;
import org.apache.iceberg.rest.RESTSessionCatalog;
import org.apache.iceberg.rest.RESTCatalog;

import java.util.Map;

Expand All @@ -43,16 +43,20 @@ public String getTestType() {
@Override
public String getErrorHint() {
return "Please check Iceberg REST Catalog URI, authentication credentials (OAuth2 or SigV4), "
+ "warehouse location, and endpoint connectivity";
+ "warehouse (location, catalog name, or S3 Tables ARN), and endpoint connectivity";
}

@Override
public void testConnection() throws Exception {
Map<String, String> restProps = ((IcebergRestProperties) properties).getIcebergRestCatalogProperties();

try (RESTSessionCatalog catalog = new RESTSessionCatalog()) {
try (RESTCatalog catalog = new RESTCatalog()) {
catalog.initialize("connectivity-test", restProps);

// Validate connection by listing namespaces.
// This verifies authentication and warehouse configuration.
catalog.listNamespaces();

Map<String, String> mergedProps = catalog.properties();
String location = mergedProps.get(CatalogProperties.WAREHOUSE_LOCATION);
this.warehouseLocation = validateLocation(location);
Expand Down
Loading