branch-3.1: [fix](load)Fix object storage protocol validation to exclude non-S3 compatible services like Azure#58491
Merged
morrySnow merged 1 commit intoapache:branch-3.1from Dec 1, 2025
Conversation
…ompatible services like Azure Based on the error message, there's a ClassCastException occurring in the LoadStmt class: Error: AzureProperties cannot be cast to ObjectStorageProperties Root Cause: The code assumes all storage properties are instances of ObjectStorageProperties, but AzureProperties doesn't extend this class Location: In the checkS3Param method where it tries to cast brokerDesc.getStorageProperties() to ObjectStorageProperties
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
CalvinKirs
changed the title
Contributor
|
run buildall |
Contributor
FE UT Coverage ReportIncrement line coverage |
morrySnow
approved these changes
Dec 1, 2025
seawinde
pushed a commit
to seawinde/doris
that referenced
this pull request
Jan 30, 2026
…ude non-S3 compatible services like Azure (apache#5993) picked from apache#58491
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
changes
Based on the error message, there's a ClassCastException occurring in the LoadStmt class:
Error: AzureProperties cannot be cast to ObjectStoragePropertiesThe current LoadStmt.checkS3Param() method has a protocol classification issue:
Over-generalized scope: The method checks all storage types using ObjectStorageProperties
Protocol confusion: Azure is an object storage service but not S3-compatible, so it shouldn't use S3-specific validation logic
Type casting error: As shown in the error, AzureProperties cannot be cast to ObjectStorageProperties
What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)