-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[fix](nereids)StatementContext must be created before creating stream load plan #58494
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
|
run buildall |
TPC-H: Total hot run time: 34265 ms |
TPC-DS: Total hot run time: 181994 ms |
ClickBench: Total hot run time: 27.73 s |
FE UT Coverage ReportIncrement line coverage |
|
run buildall |
TPC-H: Total hot run time: 34293 ms |
TPC-DS: Total hot run time: 182067 ms |
ClickBench: Total hot run time: 27.84 s |
FE UT Coverage ReportIncrement line coverage |
FE Regression Coverage ReportIncrement line coverage |
liaoxin01
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
morrySnow
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add some UT to test repeat slot id?
f0fdd71 to
feae9e1
Compare
|
run buildall |
TPC-H: Total hot run time: 34347 ms |
TPC-DS: Total hot run time: 183131 ms |
ClickBench: Total hot run time: 27.48 s |
FE Regression Coverage ReportIncrement line coverage |
|
PR approved by at least one committer and no changes requested. |
…ating stream load plan apache#58494
…ating stream load plan #58494 (#58629) … pick #58494 ### What problem does this PR solve? Issue Number: close #xxx Related PR: #xxx Problem Summary: ### Release note None ### Check List (For Author) - Test <!-- At least one of them must be included. --> - [ ] Regression test - [ ] Unit Test - [ ] Manual test (add detailed scripts or steps below) - [ ] No need to test or manual test. Explain why: - [ ] This is a refactor/code format and no logic has been changed. - [ ] Previous test can cover this change. - [ ] No code files have been changed. - [ ] Other reason <!-- Add your reason? --> - Behavior changed: - [ ] No. - [ ] Yes. <!-- Explain the behavior change --> - Does this need documentation? - [ ] No. - [ ] Yes. <!-- Add document PR link here. eg: apache/doris-website#1214 --> ### Check List (For Reviewer who merge this PR) - [ ] Confirm the release note - [ ] Confirm test cases - [ ] Confirm document - [ ] Add branch pick label <!-- Add branch pick label that this PR should merge into -->
… load plan (apache#58494) In NereidsLoadScanProvider, we call StatementScopeIdGenerator.getExprIdGenerator() to generate ExprId for column mapping exprs. But the StatementContext is not set in ConnectContext at this point. So it will use ExprIdGenerator from default StatementContext. Later when createLoadPlan for stream load, we create a new StatementContext and use a new ExprIdGenerator then. We should only use 1 ExprIdGenerator during stream load process. This pr fix it.
In NereidsLoadScanProvider, we call StatementScopeIdGenerator.getExprIdGenerator() to generate ExprId for column mapping exprs. But the StatementContext is not set in ConnectContext at this point. So it will use ExprIdGenerator from default StatementContext. Later when createLoadPlan for stream load, we create a new StatementContext and use a new ExprIdGenerator then. We should only use 1 ExprIdGenerator during stream load process. This pr fix it.
What problem does this PR solve?
Issue Number: close #xxx
Related PR: (#49116)
Problem Summary:
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)