Skip to content

[fix](nereids) Fix logicalRepeat java type convert err when start fe in ide #58510

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
morrySnow merged 1 commit into from
Dec 1, 2025
Merged

[fix](nereids) Fix logicalRepeat java type convert err when start fe in ide #58510

morrySnow merged 1 commit into from
Dec 1, 2025

Conversation

@seawinde
Copy link
Contributor

@seawinde seawinde commented Nov 28, 2025

What problem does this PR solve?

Fix logicalRepeat java type convert err when start fe in ide

Issue Number: close #xxx

Related PR: #57840

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@seawinde
Copy link
Contributor Author

seawinde commented Nov 28, 2025

run buildall

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Nov 28, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Nov 28, 2025

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 28, 2025

PR approved by anyone and no changes requested.

yujun777
yujun777 approved these changes Nov 28, 2025
View reviewed changes
Copy link
Contributor

@yujun777 yujun777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@doris-robot
Copy link

doris-robot commented Nov 28, 2025

TPC-H: Total hot run time: 34071 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit fe9bf9680f3fed9608efaf365dbdb851d9ac97d7, data reload: false

------ Round 1 ----------------------------------
q1	17658	5006	4885	4885
q2	2046	343	214	214
q3	10249	1322	722	722
q4	10242	959	366	366
q5	7557	2552	2235	2235
q6	183	172	139	139
q7	935	781	630	630
q8	9352	1399	992	992
q9	7085	5354	5367	5354
q10	6887	2216	1817	1817
q11	515	329	294	294
q12	351	377	240	240
q13	17798	3654	3001	3001
q14	234	248	225	225
q15	593	512	511	511
q16	874	866	804	804
q17	598	739	481	481
q18	7475	7047	7107	7047
q19	1091	952	575	575
q20	341	338	233	233
q21	3574	3045	2372	2372
q22	1033	1005	934	934
Total cold run time: 106671 ms
Total hot run time: 34071 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4949	4901	4905	4901
q2	328	388	327	327
q3	2121	2687	2289	2289
q4	1300	1773	1284	1284
q5	4234	4363	4548	4363
q6	236	177	133	133
q7	2065	2011	1849	1849
q8	2657	2479	2526	2479
q9	7503	7595	7482	7482
q10	3112	3216	2860	2860
q11	586	528	494	494
q12	694	764	629	629
q13	3648	3841	3266	3266
q14	337	323	321	321
q15	560	520	519	519
q16	893	945	872	872
q17	1182	1380	1441	1380
q18	7950	7562	7678	7562
q19	795	804	790	790
q20	2011	2033	1904	1904
q21	4552	4356	4126	4126
q22	1065	1033	991	991
Total cold run time: 52778 ms
Total hot run time: 50821 ms

@doris-robot
Copy link

doris-robot commented Nov 28, 2025

TPC-DS: Total hot run time: 182460 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit fe9bf9680f3fed9608efaf365dbdb851d9ac97d7, data reload: false

query1	1053	411	380	380
query2	6579	1169	1156	1156
query3	6776	224	229	224
query4	25508	23107	22741	22741
query5	4441	666	525	525
query6	381	252	237	237
query7	4667	521	320	320
query8	317	261	250	250
query9	8707	2620	2612	2612
query10	509	373	310	310
query11	15051	15069	14890	14890
query12	183	120	113	113
query13	1708	599	455	455
query14	9164	5916	5970	5916
query15	218	204	192	192
query16	7447	714	534	534
query17	1270	789	644	644
query18	2023	447	354	354
query19	226	207	196	196
query20	136	125	124	124
query21	215	149	114	114
query22	4101	4224	4157	4157
query23	33111	32308	32267	32267
query24	8544	2418	2443	2418
query25	685	561	493	493
query26	1252	284	167	167
query27	2758	521	354	354
query28	4371	2167	2151	2151
query29	866	657	539	539
query30	319	248	214	214
query31	810	711	620	620
query32	82	74	79	74
query33	617	393	348	348
query34	804	910	535	535
query35	807	832	747	747
query36	875	919	843	843
query37	119	107	85	85
query38	3801	3869	3778	3778
query39	1478	1409	1396	1396
query40	230	133	121	121
query41	63	62	61	61
query42	127	115	111	111
query43	431	432	408	408
query44	1280	767	753	753
query45	199	190	189	189
query46	882	1009	640	640
query47	1712	1749	1683	1683
query48	392	427	327	327
query49	778	516	422	422
query50	645	696	414	414
query51	3861	3977	3825	3825
query52	115	109	111	109
query53	237	265	196	196
query54	316	294	286	286
query55	98	95	96	95
query56	380	337	321	321
query57	1136	1190	1098	1098
query58	285	280	274	274
query59	2375	2328	2376	2328
query60	354	352	340	340
query61	165	159	160	159
query62	827	734	661	661
query63	227	195	189	189
query64	4567	1209	902	902
query65	4052	3971	3966	3966
query66	1172	434	334	334
query67	15175	15009	14807	14807
query68	8369	951	620	620
query69	519	349	312	312
query70	1093	1042	1022	1022
query71	486	336	313	313
query72	5939	4802	4753	4753
query73	719	580	345	345
query74	8888	8825	8653	8653
query75	3578	2999	2539	2539
query76	3730	1142	716	716
query77	799	425	308	308
query78	9463	9777	9002	9002
query79	2011	826	598	598
query80	635	573	492	492
query81	494	270	235	235
query82	473	141	118	118
query83	273	258	245	245
query84	262	113	93	93
query85	998	485	440	440
query86	346	298	308	298
query87	3998	4052	4044	4044
query88	3576	2268	2289	2268
query89	404	336	305	305
query90	1927	231	225	225
query91	187	175	139	139
query92	85	67	77	67
query93	1134	1012	679	679
query94	715	455	344	344
query95	501	399	399	399
query96	526	568	289	289
query97	2633	2713	2618	2618
query98	238	222	220	220
query99	1315	1364	1269	1269
Total cold run time: 270374 ms
Total hot run time: 182460 ms

@doris-robot
Copy link

doris-robot commented Nov 28, 2025

ClickBench: Total hot run time: 27.23 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit fe9bf9680f3fed9608efaf365dbdb851d9ac97d7, data reload: false

query1	0.06	0.05	0.05
query2	0.10	0.05	0.04
query3	0.25	0.09	0.09
query4	1.61	0.11	0.11
query5	0.26	0.27	0.28
query6	1.15	0.65	0.63
query7	0.04	0.02	0.03
query8	0.06	0.04	0.05
query9	0.58	0.51	0.50
query10	0.56	0.56	0.54
query11	0.15	0.11	0.11
query12	0.16	0.12	0.11
query13	0.63	0.60	0.60
query14	0.98	0.98	0.98
query15	0.83	0.79	0.80
query16	0.41	0.40	0.39
query17	1.04	1.03	1.08
query18	0.23	0.22	0.22
query19	1.93	1.88	1.78
query20	0.02	0.01	0.01
query21	15.44	0.25	0.13
query22	4.66	0.05	0.05
query23	15.91	0.27	0.09
query24	1.16	0.24	1.17
query25	0.11	0.05	0.05
query26	0.13	0.13	0.14
query27	0.05	0.05	0.06
query28	4.91	1.21	1.02
query29	12.59	3.82	3.29
query30	0.31	0.13	0.12
query31	2.82	0.61	0.40
query32	3.24	0.54	0.46
query33	3.00	3.06	3.01
query34	16.73	5.22	4.52
query35	4.58	4.56	4.54
query36	0.67	0.50	0.48
query37	0.11	0.06	0.07
query38	0.08	0.04	0.04
query39	0.04	0.03	0.02
query40	0.16	0.15	0.14
query41	0.09	0.04	0.03
query42	0.04	0.03	0.02
query43	0.04	0.03	0.04
Total cold run time: 97.92 s
Total hot run time: 27.23 s

@hello-stephen
Copy link
Contributor

hello-stephen commented Nov 28, 2025

FE Regression Coverage Report

Increment line coverage 100.00% (1/1) 🎉
Increment coverage report
Complete coverage report

@morrySnow morrySnow merged commit 680ee1c into apache:master Dec 1, 2025
31 checks passed
github-actions bot pushed a commit that referenced this pull request Dec 1, 2025
@seawinde
[fix](nereids) Fix logicalRepeat java type convert err when start fe …
098db6e 
…in ide (#58510)

Related PR: #57840
@github-actions github-actions bot mentioned this pull request Dec 1, 2025
Merged
github-actions bot pushed a commit that referenced this pull request Dec 1, 2025
@seawinde
[fix](nereids) Fix logicalRepeat java type convert err when start fe …
74909a2 
…in ide (#58510)

Related PR: #57840
@github-actions github-actions bot mentioned this pull request Dec 1, 2025
Merged
yiguolei pushed a commit that referenced this pull request Dec 2, 2025
@github-actions @seawinde
branch-4.0: [fix](nereids) Fix logicalRepeat java type convert err wh…
0a0ec5b 
…en start fe in ide #58510 (#58549)

Cherry-picked from #58510

Co-authored-by: seawinde <wusi@selectdb.com>
morrySnow pushed a commit that referenced this pull request Dec 2, 2025
@github-actions @seawinde
branch-3.1: [fix](nereids) Fix logicalRepeat java type convert err wh…
7d06dfe 
…en start fe in ide #58510 (#58548)

Cherry-picked from #58510

Co-authored-by: seawinde <wusi@selectdb.com>
nagisa-kunhah pushed a commit to nagisa-kunhah/doris that referenced this pull request Dec 14, 2025
@seawinde @nagisa-kunhah
[fix](nereids) Fix logicalRepeat java type convert err when start fe …
01cc242 
…in ide (apache#58510)

Related PR: apache#57840
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@morrySnow morrySnow morrySnow approved these changes

+1 more reviewer

@yujun777 yujun777 yujun777 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. dev/3.1.4-merged dev/4.0.2-merged reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@seawinde @doris-robot @hello-stephen @yujun777 @morrySnow @yiguolei