[Bug-fix][Backup] Modify the persistence logic of backup and restore #5853
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The expose annotation is used in the persistence logic used by the old backup recovery. This annotation by itself is meant to ignore some variables when serializing and deserializing. However, this variable was used incorrectly and gson did not ignore the variables that should have been ignored. This results in duplicate initialization when fe is restarted. This pr uses the doris wrapped Gson directly, than eliminates the use of the expose annotation. Fixed sortedTabletInfoList being repeatedly initialized resulting in incorrect numbers. Fixed apache#5852
EmmyMiao87
added
kind/fix
stdpain
pushed a commit
to stdpain/incubator-doris
that referenced
this pull request
Jul 8, 2021
…pache#5853) The expose annotation is used in the persistence logic used by the old backup recovery. This annotation by itself is meant to ignore some variables when serializing and deserializing. However, this variable was used incorrectly and gson did not ignore the variables that should have been ignored. This results in duplicate initialization when fe is restarted. This pr uses the doris wrapped Gson directly, than eliminates the use of the expose annotation. Fixed sortedTabletInfoList being repeatedly initialized resulting in incorrect numbers. Fixed apache#5852
w41ter
pushed a commit
to w41ter/incubator-doris
that referenced
this pull request
Dec 26, 2025
…er versions apache#58135 (apache#5853) pick from apache#58135
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The expose annotation is used in the persistence logic used by the old backup recovery.
This annotation by itself is meant to ignore some variables when serializing and deserializing.
However, this variable was used incorrectly and gson did not ignore the variables that should have been ignored.
This results in duplicate initialization when fe is restarted.
This pr uses the doris wrapped Gson directly, than eliminates the use of the expose annotation.
Fixed sortedTabletInfoList being repeatedly initialized resulting in incorrect numbers.
Fixed #5852
Types of changes
What types of changes does your code introduce to Doris?
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.