Skip to content

[chore](security) Add ssrf check for create stage #58585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
gavinchou merged 1 commit into from
Dec 9, 2025
Merged

[chore](security) Add ssrf check for create stage #58585

gavinchou merged 1 commit into from
Dec 9, 2025

Conversation

@gavinchou
Copy link
Contributor

@gavinchou gavinchou commented Dec 1, 2025

No description provided.

@Thearas
Copy link
Contributor

Thearas commented Dec 1, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@gavinchou
Copy link
Contributor Author

gavinchou commented Dec 1, 2025

run buildall

1 similar comment
@gavinchou
Copy link
Contributor Author

gavinchou commented Dec 1, 2025

run buildall

@gavinchou gavinchou force-pushed the gavin-fix-some-ssrf branch from 915bca7 to ab2d371 Compare December 2, 2025 02:56
@gavinchou
Copy link
Contributor Author

gavinchou commented Dec 3, 2025

run buildall

@doris-robot
Copy link

doris-robot commented Dec 3, 2025

TPC-H: Total hot run time: 34449 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit ab2d37164eaf09600cb888bbf7e7163ddafb160d, data reload: false

------ Round 1 ----------------------------------
q1	17675	5121	4939	4939
q2	2071	323	214	214
q3	10219	1302	778	778
q4	10240	917	330	330
q5	7535	2416	2167	2167
q6	202	166	136	136
q7	942	792	651	651
q8	9355	1455	1133	1133
q9	7097	5413	5269	5269
q10	6825	2205	1764	1764
q11	523	318	283	283
q12	348	377	230	230
q13	17793	3685	3049	3049
q14	234	232	214	214
q15	586	513	530	513
q16	898	860	823	823
q17	673	774	570	570
q18	7538	6956	7135	6956
q19	1199	974	630	630
q20	371	361	237	237
q21	4004	3313	2578	2578
q22	1042	1079	985	985
Total cold run time: 107370 ms
Total hot run time: 34449 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5091	4996	5042	4996
q2	320	385	300	300
q3	2170	2690	2315	2315
q4	1320	1769	1302	1302
q5	4248	4546	4463	4463
q6	231	176	134	134
q7	2061	1933	1814	1814
q8	2741	2484	2515	2484
q9	7587	7575	7543	7543
q10	3061	3240	2872	2872
q11	604	522	503	503
q12	669	757	605	605
q13	3579	3893	3345	3345
q14	305	317	307	307
q15	559	506	510	506
q16	907	922	877	877
q17	1205	1485	1478	1478
q18	7889	7726	7596	7596
q19	862	838	859	838
q20	1886	1960	1840	1840
q21	4637	4285	4103	4103
q22	1063	1054	980	980
Total cold run time: 52995 ms
Total hot run time: 51201 ms

@doris-robot
Copy link

doris-robot commented Dec 3, 2025

TPC-DS: Total hot run time: 182882 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit ab2d37164eaf09600cb888bbf7e7163ddafb160d, data reload: false

query1	1068	406	407	406
query2	6582	1159	1170	1159
query3	6742	235	226	226
query4	25137	23126	22978	22978
query5	5481	654	502	502
query6	351	249	229	229
query7	4651	526	316	316
query8	309	262	245	245
query9	8750	2691	2706	2691
query10	579	349	307	307
query11	15498	15110	14821	14821
query12	187	122	116	116
query13	1699	596	451	451
query14	9952	6110	6050	6050
query15	216	204	186	186
query16	7683	709	549	549
query17	1302	833	630	630
query18	2032	428	355	355
query19	213	204	181	181
query20	141	127	123	123
query21	214	142	115	115
query22	4042	3933	3915	3915
query23	32837	32080	32127	32080
query24	8325	2420	2483	2420
query25	607	548	486	486
query26	958	280	168	168
query27	2706	526	351	351
query28	4331	2181	2169	2169
query29	760	631	496	496
query30	314	247	217	217
query31	822	729	619	619
query32	86	78	77	77
query33	610	438	331	331
query34	844	918	555	555
query35	791	869	765	765
query36	890	948	848	848
query37	122	113	92	92
query38	3896	3851	3835	3835
query39	1487	1462	1385	1385
query40	222	137	122	122
query41	69	62	61	61
query42	125	115	116	115
query43	452	450	413	413
query44	1392	764	739	739
query45	197	199	185	185
query46	935	1036	676	676
query47	1695	1726	1630	1630
query48	410	443	334	334
query49	730	519	419	419
query50	726	703	431	431
query51	3829	3981	3957	3957
query52	111	115	121	115
query53	246	264	195	195
query54	323	305	287	287
query55	100	102	93	93
query56	363	335	325	325
query57	1128	1175	1095	1095
query58	300	292	287	287
query59	2330	2407	2297	2297
query60	355	356	374	356
query61	167	162	182	162
query62	790	725	662	662
query63	235	200	197	197
query64	3851	1216	928	928
query65	4073	4029	3982	3982
query66	916	444	339	339
query67	15342	14987	14769	14769
query68	4580	1032	646	646
query69	527	353	320	320
query70	1082	1062	1029	1029
query71	430	356	334	334
query72	5485	4977	4997	4977
query73	683	594	356	356
query74	8889	8877	8646	8646
query75	3063	3063	2565	2565
query76	3191	1169	787	787
query77	525	450	347	347
query78	9477	9850	8908	8908
query79	1220	869	586	586
query80	1579	657	525	525
query81	553	276	242	242
query82	431	153	124	124
query83	388	312	258	258
query84	263	128	98	98
query85	937	490	445	445
query86	425	308	259	259
query87	4090	4122	3949	3949
query88	3046	2387	2334	2334
query89	406	340	297	297
query90	1614	228	220	220
query91	174	173	145	145
query92	74	69	72	69
query93	1200	1033	661	661
query94	741	453	352	352
query95	515	420	424	420
query96	554	550	291	291
query97	2591	2695	2584	2584
query98	234	214	219	214
query99	1329	1418	1278	1278
Total cold run time: 264923 ms
Total hot run time: 182882 ms

@doris-robot
Copy link

doris-robot commented Dec 3, 2025

ClickBench: Total hot run time: 27.45 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit ab2d37164eaf09600cb888bbf7e7163ddafb160d, data reload: false

query1	0.05	0.05	0.05
query2	0.10	0.05	0.05
query3	0.26	0.08	0.08
query4	1.62	0.11	0.12
query5	0.28	0.26	0.26
query6	1.18	0.65	0.64
query7	0.03	0.02	0.03
query8	0.06	0.04	0.04
query9	0.58	0.51	0.50
query10	0.57	0.56	0.56
query11	0.17	0.10	0.10
query12	0.15	0.11	0.12
query13	0.63	0.61	0.60
query14	0.98	0.98	1.00
query15	0.84	0.81	0.82
query16	0.41	0.40	0.42
query17	1.07	1.11	1.01
query18	0.23	0.24	0.22
query19	1.93	1.89	1.90
query20	0.02	0.01	0.02
query21	15.43	0.29	0.14
query22	4.87	0.06	0.05
query23	16.19	0.28	0.10
query24	1.38	0.24	0.28
query25	0.07	0.06	0.05
query26	0.15	0.14	0.14
query27	0.10	0.06	0.05
query28	3.88	1.23	1.03
query29	12.62	4.04	3.29
query30	0.27	0.15	0.11
query31	2.83	0.63	0.40
query32	3.24	0.57	0.47
query33	3.09	3.01	3.13
query34	16.84	5.24	4.55
query35	4.58	4.53	4.62
query36	0.66	0.50	0.49
query37	0.11	0.07	0.06
query38	0.07	0.05	0.04
query39	0.05	0.03	0.03
query40	0.17	0.14	0.14
query41	0.09	0.04	0.03
query42	0.04	0.03	0.03
query43	0.04	0.03	0.04
Total cold run time: 97.93 s
Total hot run time: 27.45 s

@hello-stephen
Copy link
Contributor

hello-stephen commented Dec 3, 2025

FE Regression Coverage Report

Increment line coverage 100.00% (2/2) 🎉
Increment coverage report
Complete coverage report

@github-actions
Copy link
Contributor

github-actions bot commented Dec 9, 2025

PR approved by anyone and no changes requested.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Dec 9, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Dec 9, 2025

PR approved by at least one committer and no changes requested.

@gavinchou gavinchou merged commit 955ac51 into apache:master Dec 9, 2025
30 checks passed
github-actions bot pushed a commit that referenced this pull request Dec 9, 2025
@gavinchou
[chore](security) Add ssrf check for create stage (#58585)
7077f20
@github-actions github-actions bot mentioned this pull request Dec 9, 2025
Merged
github-actions bot pushed a commit that referenced this pull request Dec 9, 2025
@gavinchou
[chore](security) Add ssrf check for create stage (#58585)
0b6203e
@github-actions github-actions bot mentioned this pull request Dec 9, 2025
Merged
morrySnow pushed a commit that referenced this pull request Dec 10, 2025
@github-actions @gavinchou
branch-3.1: [chore](security) Add ssrf check for create stage #58585 (#…
6125a4e 
…58874)

Cherry-picked from #58585

Co-authored-by: Gavin Chou <gavin@selectdb.com>
yiguolei pushed a commit that referenced this pull request Dec 11, 2025
@github-actions @gavinchou
branch-4.0: [chore](security) Add ssrf check for create stage #58585 (#…
1805466 
…58875)

Cherry-picked from #58585

Co-authored-by: Gavin Chou <gavin@selectdb.com>
nagisa-kunhah pushed a commit to nagisa-kunhah/doris that referenced this pull request Dec 14, 2025
@gavinchou @nagisa-kunhah
[chore](security) Add ssrf check for create stage (apache#58585)
e15d3e0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@w41ter w41ter w41ter approved these changes

+1 more reviewer

@koarz koarz koarz approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. dev/3.1.4-merged dev/4.0.3-merged reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@gavinchou @Thearas @doris-robot @hello-stephen @w41ter @koarz @morrySnow