Skip to content

Conversation

@mymeiyi
Copy link
Contributor

@mymeiyi mymeiyi commented Dec 3, 2025

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@hello-stephen
Copy link
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@mymeiyi mymeiyi force-pushed the fix-group-commit branch 3 times, most recently from f940f23 to 2ecd286 Compare December 3, 2025 08:20
Copy link
Contributor

@deardeng deardeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

github-actions bot commented Dec 3, 2025

PR approved by anyone and no changes requested.

@mymeiyi
Copy link
Contributor Author

mymeiyi commented Dec 3, 2025

run buildall

@mymeiyi
Copy link
Contributor Author

mymeiyi commented Dec 3, 2025

run buildall

@hello-stephen
Copy link
Contributor

FE UT Coverage Report

Increment line coverage 0.00% (0/5) 🎉
Increment coverage report
Complete coverage report

@doris-robot
Copy link

TPC-H: Total hot run time: 34398 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 01749a0f9b674e21a17624249e958df8514bbe6a, data reload: false

------ Round 1 ----------------------------------
q1	17660	5091	4894	4894
q2	2054	315	220	220
q3	10259	1297	750	750
q4	10236	909	323	323
q5	7522	2424	2258	2258
q6	189	185	142	142
q7	965	789	642	642
q8	9356	1430	1121	1121
q9	7180	5403	5364	5364
q10	6879	2189	1784	1784
q11	513	328	287	287
q12	371	368	221	221
q13	17803	3683	3021	3021
q14	237	232	226	226
q15	593	508	511	508
q16	895	872	831	831
q17	685	807	512	512
q18	7501	7116	6940	6940
q19	1115	970	622	622
q20	382	357	236	236
q21	4021	3443	2555	2555
q22	1047	1007	941	941
Total cold run time: 107463 ms
Total hot run time: 34398 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4946	4917	4877	4877
q2	310	400	328	328
q3	2166	2679	2315	2315
q4	1346	1742	1309	1309
q5	4247	4487	4560	4487
q6	230	179	138	138
q7	2073	1986	1819	1819
q8	2760	2638	2528	2528
q9	7586	7538	7596	7538
q10	3069	3267	2813	2813
q11	601	534	502	502
q12	685	764	643	643
q13	3605	3835	3358	3358
q14	298	325	293	293
q15	565	513	542	513
q16	923	959	889	889
q17	1201	1417	1395	1395
q18	7868	7689	7694	7689
q19	921	886	876	876
q20	2161	2031	1980	1980
q21	4692	4325	4231	4231
q22	1068	1078	971	971
Total cold run time: 53321 ms
Total hot run time: 51492 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 182486 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 01749a0f9b674e21a17624249e958df8514bbe6a, data reload: false

query1	1035	440	391	391
query2	6614	1167	1145	1145
query3	6748	235	226	226
query4	25940	23293	22910	22910
query5	4896	674	511	511
query6	343	245	225	225
query7	4672	536	328	328
query8	297	252	254	252
query9	8718	2651	2649	2649
query10	557	360	315	315
query11	15568	14903	15109	14903
query12	188	124	117	117
query13	1703	590	504	504
query14	9607	5898	5962	5898
query15	212	201	187	187
query16	7517	696	536	536
query17	1220	786	638	638
query18	2041	454	350	350
query19	221	214	185	185
query20	132	129	123	123
query21	218	136	115	115
query22	3840	4109	3885	3885
query23	33250	32021	32078	32021
query24	8457	2452	2455	2452
query25	626	556	505	505
query26	779	295	173	173
query27	2672	509	351	351
query28	4301	2207	2194	2194
query29	780	668	518	518
query30	315	250	222	222
query31	809	709	628	628
query32	84	74	78	74
query33	614	411	347	347
query34	872	878	545	545
query35	790	837	750	750
query36	902	919	835	835
query37	126	117	90	90
query38	3879	3869	3805	3805
query39	1496	1444	1411	1411
query40	230	132	120	120
query41	66	64	63	63
query42	132	121	117	117
query43	449	455	440	440
query44	1329	763	762	762
query45	204	192	183	183
query46	920	1038	674	674
query47	1703	1726	1671	1671
query48	408	426	318	318
query49	755	518	427	427
query50	690	712	406	406
query51	3819	3919	3888	3888
query52	115	109	110	109
query53	245	262	196	196
query54	311	293	276	276
query55	97	97	89	89
query56	333	328	344	328
query57	1139	1181	1097	1097
query58	295	289	272	272
query59	2377	2421	2367	2367
query60	350	348	339	339
query61	157	158	156	156
query62	818	724	655	655
query63	229	197	188	188
query64	3567	1258	936	936
query65	4037	3971	3959	3959
query66	976	457	337	337
query67	15631	15149	14836	14836
query68	8314	991	644	644
query69	524	348	302	302
query70	1070	1010	1016	1010
query71	477	336	310	310
query72	5837	4882	4875	4875
query73	729	577	349	349
query74	8710	8763	8642	8642
query75	3674	3024	2567	2567
query76	3723	1148	738	738
query77	822	401	316	316
query78	9416	9752	8911	8911
query79	1824	846	586	586
query80	646	614	487	487
query81	493	273	242	242
query82	461	139	115	115
query83	275	261	251	251
query84	256	123	99	99
query85	1026	500	461	461
query86	335	297	309	297
query87	4100	4044	3969	3969
query88	3375	2304	2285	2285
query89	392	341	303	303
query90	1971	228	223	223
query91	169	176	152	152
query92	82	69	65	65
query93	1168	1025	689	689
query94	706	443	334	334
query95	511	409	406	406
query96	533	549	289	289
query97	2684	2691	2574	2574
query98	236	223	207	207
query99	1305	1398	1265	1265
Total cold run time: 270265 ms
Total hot run time: 182486 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 27.52 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 01749a0f9b674e21a17624249e958df8514bbe6a, data reload: false

query1	0.06	0.05	0.05
query2	0.10	0.05	0.05
query3	0.26	0.09	0.09
query4	1.61	0.12	0.11
query5	0.29	0.26	0.27
query6	1.18	0.65	0.63
query7	0.04	0.03	0.03
query8	0.05	0.04	0.04
query9	0.57	0.51	0.50
query10	0.55	0.55	0.54
query11	0.15	0.11	0.11
query12	0.15	0.12	0.12
query13	0.62	0.62	0.61
query14	1.00	0.98	0.98
query15	0.83	0.79	0.81
query16	0.39	0.41	0.40
query17	1.04	1.00	0.99
query18	0.25	0.21	0.23
query19	1.84	1.91	1.85
query20	0.02	0.02	0.01
query21	15.43	0.29	0.14
query22	4.80	0.05	0.05
query23	15.99	0.28	0.11
query24	1.06	0.25	0.46
query25	0.06	0.07	0.08
query26	0.15	0.13	0.13
query27	0.08	0.06	0.05
query28	3.89	1.22	1.02
query29	12.62	3.99	3.22
query30	0.28	0.14	0.12
query31	2.81	0.63	0.40
query32	3.23	0.56	0.46
query33	3.05	3.16	3.22
query34	16.81	5.24	4.60
query35	4.60	4.53	4.56
query36	0.65	0.50	0.50
query37	0.11	0.07	0.07
query38	0.07	0.05	0.04
query39	0.05	0.03	0.03
query40	0.17	0.14	0.12
query41	0.09	0.04	0.03
query42	0.04	0.02	0.02
query43	0.04	0.04	0.03
Total cold run time: 97.08 s
Total hot run time: 27.52 s

@hello-stephen
Copy link
Contributor

FE Regression Coverage Report

Increment line coverage 0.00% (0/5) 🎉
Increment coverage report
Complete coverage report

Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

github-actions bot commented Dec 4, 2025

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Dec 4, 2025
@dataroaring dataroaring merged commit 48bffdc into apache:master Dec 4, 2025
26 checks passed
yiguolei pushed a commit that referenced this pull request Dec 5, 2025
…kend #58676 (#58712)

Cherry-picked from #58676

Co-authored-by: meiyi <meiyi@selectdb.com>
nagisa-kunhah pushed a commit to nagisa-kunhah/doris that referenced this pull request Dec 14, 2025
mymeiyi added a commit to mymeiyi/doris that referenced this pull request Dec 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. dev/3.1.4-merged dev/4.0.2-merged reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants