Skip to content

Conversation

@feiniaofeiafei
Copy link
Contributor

@feiniaofeiafei feiniaofeiafei commented Dec 11, 2025

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:
1.Query like this will use cte to split and compute agg before this pr, but it is not necessary.
select count(distinct a),sum(distinct a) from t1;
after this pr, it will not split.
2.Query like this will report error:
select array_agg(distinct a), array_agg(distinct b) from t1;

errCode = 2, detailMessage = array_agg(DISTINCT a#1) can't support multi distinct. 

after this pr, the query will use cte to split and compute, and will not report error.

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@Thearas
Copy link
Contributor

Thearas commented Dec 11, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@feiniaofeiafei
Copy link
Contributor Author

run buildall

@feiniaofeiafei
Copy link
Contributor Author

run p0

@morrySnow
Copy link
Contributor

add desc and releated pr

@feiniaofeiafei
Copy link
Contributor Author

run buildall

@feiniaofeiafei feiniaofeiafei force-pushed the make_split_multi_distinct_support_more branch from e1ab22c to 175fc72 Compare December 16, 2025 11:47
@feiniaofeiafei
Copy link
Contributor Author

run buildall

@hello-stephen
Copy link
Contributor

FE UT Coverage Report

Increment line coverage 33.33% (2/6) 🎉
Increment coverage report
Complete coverage report

@feiniaofeiafei feiniaofeiafei force-pushed the make_split_multi_distinct_support_more branch 2 times, most recently from ba6f4ba to 3d7bf2e Compare December 18, 2025 09:17
@feiniaofeiafei
Copy link
Contributor Author

run buildall

@feiniaofeiafei feiniaofeiafei force-pushed the make_split_multi_distinct_support_more branch from 3d7bf2e to d2d50b7 Compare December 18, 2025 09:50
@feiniaofeiafei
Copy link
Contributor Author

run buildall

@feiniaofeiafei
Copy link
Contributor Author

run nonConcurrent

@morrySnow morrySnow changed the title [enhance](agg) Make aggfuncs that not support multi_distinct can be split in splitMultiDistinct branch-3.1: [enhance](agg) Make aggfuncs that not support multi_distinct can be split in splitMultiDistinct Dec 19, 2025
@morrySnow morrySnow merged commit c3fd70c into apache:branch-3.1 Dec 19, 2025
21 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants