-
Notifications
You must be signed in to change notification settings - Fork 3.7k
branch-3.1: [enhance](agg) Make aggfuncs that not support multi_distinct can be split in splitMultiDistinct #58973
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
morrySnow
merged 4 commits into
apache:branch-3.1
from
feiniaofeiafei:make_split_multi_distinct_support_more
Dec 19, 2025
Merged
branch-3.1: [enhance](agg) Make aggfuncs that not support multi_distinct can be split in splitMultiDistinct #58973
morrySnow
merged 4 commits into
apache:branch-3.1
from
feiniaofeiafei:make_split_multi_distinct_support_more
Dec 19, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
Author
|
run buildall |
Contributor
Author
|
run p0 |
Contributor
|
add desc and releated pr |
Contributor
Author
|
run buildall |
e1ab22c to
175fc72
Compare
Contributor
Author
|
run buildall |
Contributor
FE UT Coverage ReportIncrement line coverage |
ba6f4ba to
3d7bf2e
Compare
Contributor
Author
|
run buildall |
3d7bf2e to
d2d50b7
Compare
Contributor
Author
|
run buildall |
Contributor
Author
|
run nonConcurrent |
morrySnow
approved these changes
Dec 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
1.Query like this will use cte to split and compute agg before this pr, but it is not necessary.
select count(distinct a),sum(distinct a) from t1;
after this pr, it will not split.
2.Query like this will report error:
select array_agg(distinct a), array_agg(distinct b) from t1;
errCode = 2, detailMessage = array_agg(DISTINCT a#1) can't support multi distinct.after this pr, the query will use cte to split and compute, and will not report error.
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)