Skip to content

[fix](mtmv) Fix mv rewrite failed when mv is rewritten by LimitAggToTopNAgg but query is not #58974

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
starocean999 merged 3 commits into from
Dec 16, 2025
Merged

[fix](mtmv) Fix mv rewrite failed when mv is rewritten by LimitAggToTopNAgg but query is not #58974

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
85d0a21
[fix](mtmv) Fix mv rewrite failed when mv is rewritten by LimitAggToT…
seawinde Dec 11, 2025
7f01f36
fix fuzzy variable bigger to make test case stable
seawinde Dec 12, 2025
9d6d48c
add log to position problem
seawinde Dec 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions fe/fe-core/src/main/java/org/apache/doris/qe/SessionVariable.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3285,8 +3285,11 @@ public void initFuzzyModeVariables() {
}
this.runtimeFilterWaitInfinitely = random.nextBoolean();

// set random 1, 10, 100, 1000, 10000
this.topnOptLimitThreshold = (int) Math.pow(10, random.nextInt(5));
// set random 101, 100, 1000, 10000, should be greater than 100, because small limit may lead
// some test case failed, e.g. topN with limit 100 may not hit the LimitAggToTopNAgg rule
// optimization when fuzzy
int randomLimitThreshold = (int) Math.pow(10, random.nextInt(5));
this.topnOptLimitThreshold = randomLimitThreshold <= 100 ? 101 : randomLimitThreshold;

// for spill to disk
if (Config.fuzzy_test_type.equals("p0")) {
Expand Down
4 changes: 4 additions & 0 deletions ...est/suites/nereids_rules_p0/mv/agg_optimize_when_uniform/agg_optimize_when_uniform.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -379,6 +379,10 @@ suite("agg_optimize_when_uniform") {
def plan_6 = sql """explain verbose ${query6_0}"""
logger.info("plan_6 is " + plan_6)

// This line of code is modified to position the occasional error: "null value is not in not null slot".
def query_mv6 = sql """select sum(__bin_4 is null) from mv6_0"""
logger.info("query_mv6 is " + query_mv6)

order_qt_query6_0_after "${query6_0}"
sql """ DROP MATERIALIZED VIEW IF EXISTS mv6_0"""

Expand Down