Skip to content

Conversation

@liaoxin01
Copy link
Contributor

@liaoxin01 liaoxin01 commented Dec 11, 2025

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #57770

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

Copilot AI review requested due to automatic review settings December 11, 2025 12:50
@Thearas
Copy link
Contributor

Thearas commented Dec 11, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@liaoxin01
Copy link
Contributor Author

run buildall

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR refactors the small file packing feature by renaming "merge_file" terminology to "packed_file" across multiple test files. The change improves naming consistency and clarity by using "packed_file" instead of "merge_file" for the feature that packs small files together. The refactoring updates function names, variable names, configuration keys, metric names, and documentation comments.

Key changes:

  • Updated configuration key from enable_merge_file to enable_packed_file
  • Renamed metrics from merge_file_total_small_file_num to packed_file_total_small_file_num
  • Updated all function names, variable names, and comments to use "packed_file" terminology

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

File Description
test_packed_file_with_group_commit.groovy Updated function names, variables, config keys, metric names, and comments from "merge_file" to "packed_file" terminology
test_packed_file_query_with_table_drop.groovy Updated configuration key from enable_merge_file to enable_packed_file
test_packed_file_mixed_load.groovy Updated function names, variables, metric names, and comments from "merge_file" to "packed_file" terminology
test_packed_file_concurrent_load.groovy Updated function names, variables, metric names, and comments from "merge_file" to "packed_file" terminology

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

// This test verifies that merge file logic works correctly when group commit is enabled
// Test case: Packed file with group commit enabled
// This test verifies that packed file logic works correctly when group commit is enabled
def tableName = "test_merge_file_with_group_commit"
Copy link

Copilot AI Dec 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The table name still uses the old "test_merge_file_" prefix. For consistency with the refactoring from "merge_file" to "packed_file", this should be renamed to "test_packed_file_with_group_commit".

Suggested change
def tableName = "test_merge_file_with_group_commit"
def tableName = "test_packed_file_with_group_commit"

Copilot uses AI. Check for mistakes.
@liaoxin01
Copy link
Contributor Author

run buildall

@gavinchou gavinchou changed the title [fix](packed-file) fix some case for pack small files [fix](packed-file) fix some case for packed small files Dec 12, 2025
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added approved Indicates a PR has been approved by one committer. reviewed labels Dec 12, 2025
@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@liaoxin01 liaoxin01 merged commit 4502d12 into apache:master Dec 15, 2025
29 of 30 checks passed
@liaoxin01 liaoxin01 deleted the fix_merge_file_case branch December 15, 2025 07:53
liaoxin01 added a commit to liaoxin01/doris that referenced this pull request Jan 8, 2026
liaoxin01 added a commit to liaoxin01/doris that referenced this pull request Jan 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. dev/4.0.3-merged packed-file reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants