-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[fix](packed-file) fix some case for packed small files #58977
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
|
run buildall |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR refactors the small file packing feature by renaming "merge_file" terminology to "packed_file" across multiple test files. The change improves naming consistency and clarity by using "packed_file" instead of "merge_file" for the feature that packs small files together. The refactoring updates function names, variable names, configuration keys, metric names, and documentation comments.
Key changes:
- Updated configuration key from
enable_merge_filetoenable_packed_file - Renamed metrics from
merge_file_total_small_file_numtopacked_file_total_small_file_num - Updated all function names, variable names, and comments to use "packed_file" terminology
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| test_packed_file_with_group_commit.groovy | Updated function names, variables, config keys, metric names, and comments from "merge_file" to "packed_file" terminology |
| test_packed_file_query_with_table_drop.groovy | Updated configuration key from enable_merge_file to enable_packed_file |
| test_packed_file_mixed_load.groovy | Updated function names, variables, metric names, and comments from "merge_file" to "packed_file" terminology |
| test_packed_file_concurrent_load.groovy | Updated function names, variables, metric names, and comments from "merge_file" to "packed_file" terminology |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| // This test verifies that merge file logic works correctly when group commit is enabled | ||
| // Test case: Packed file with group commit enabled | ||
| // This test verifies that packed file logic works correctly when group commit is enabled | ||
| def tableName = "test_merge_file_with_group_commit" |
Copilot
AI
Dec 11, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The table name still uses the old "test_merge_file_" prefix. For consistency with the refactoring from "merge_file" to "packed_file", this should be renamed to "test_packed_file_with_group_commit".
| def tableName = "test_merge_file_with_group_commit" | |
| def tableName = "test_packed_file_with_group_commit" |
regression-test/suites/cloud_p0/packed_file/test_packed_file_concurrent_load.groovy
Outdated
Show resolved
Hide resolved
regression-test/suites/cloud_p0/packed_file/test_packed_file_concurrent_load.groovy
Outdated
Show resolved
Hide resolved
|
run buildall |
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
What problem does this PR solve?
Issue Number: close #xxx
Related PR: #57770
Problem Summary:
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)