[opt](cloud) optimize load performance for inverted index when pack small files #59011
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
Author
|
run buildall |
There was a problem hiding this comment.
Pull request overview
This PR optimizes the load performance for inverted indexes when packing small files by introducing non-blocking file writer close operations and adding explicit file writer cleanup logic.
Key Changes
- Changed file writer close operation to non-blocking mode (
close(true)) in FSIndexOutputV2 to improve performance - Added explicit cleanup loop in SegmentFlusher::close() to ensure all index file writers' underlying file writers are properly closed
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| be/src/olap/rowset/segment_v2/inverted_index_fs_directory.cpp | Modified FSIndexOutputV2::close() to use non-blocking close (close(true)) for the underlying file writer to improve performance |
| be/src/olap/rowset/segment_creator.cpp | Added explicit loop to close underlying file writers after closing the index file collection, ensuring proper resource cleanup even if errors occur during the close chain |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
TPC-H: Total hot run time: 36035 ms |
TPC-DS: Total hot run time: 178491 ms |
ClickBench: Total hot run time: 27.31 s |
Contributor
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
liaoxin01
force-pushed
the
opt_pack_for_idx_load
branch
from
1edde83 to
2e5391a
Compare
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 36456 ms |
TPC-DS: Total hot run time: 178672 ms |
ClickBench: Total hot run time: 27.3 s |
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 34973 ms |
TPC-DS: Total hot run time: 177439 ms |
ClickBench: Total hot run time: 27.13 s |
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 35195 ms |
TPC-DS: Total hot run time: 178442 ms |
ClickBench: Total hot run time: 27.95 s |
liaoxin01
force-pushed
the
opt_pack_for_idx_load
branch
from
2e5391a to
05424bc
Compare
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 36514 ms |
TPC-DS: Total hot run time: 178401 ms |
ClickBench: Total hot run time: 27.32 s |
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
airborne12
reviewed
Dec 23, 2025
Contributor
Author
|
run buildall |
liaoxin01
force-pushed
the
opt_pack_for_idx_load
branch
from
fa17d90 to
2023b08
Compare
Contributor
Author
|
run buildall |
airborne12
reviewed
Dec 23, 2025
TPC-H: Total hot run time: 36545 ms |
TPC-DS: Total hot run time: 178672 ms |
ClickBench: Total hot run time: 27.11 s |
Contributor
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
Author
|
run buildall |
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
TPC-H: Total hot run time: 35195 ms |
TPC-DS: Total hot run time: 179329 ms |
ClickBench: Total hot run time: 27.45 s |
Contributor
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
luwei16
approved these changes
Dec 25, 2025
liaoxin01
added a commit
to liaoxin01/doris
that referenced
this pull request
Jan 8, 2026
…mall files (apache#59011) Related PR: apache#57770 Problem Summary: When merging small files with inverted indexes, the segment close operation was synchronously waiting for inverted index files to be uploaded to S3. This blocking behavior significantly impacted the memtable flush thread performance, causing bottlenecks in the data loading pipeline. Solution: The solution introduces a two-phase close mechanism for inverted index file writers: 1. **Asynchronous Close Phase**: During segment close, inverted index files are closed asynchronously and the S3 upload task is submitted immediately without waiting for completion. 2. **Wait Phase**: When the load channel closes, the system waits for all pending S3 upload tasks to complete, ensuring data consistency.
liaoxin01
added a commit
to liaoxin01/doris
that referenced
this pull request
Jan 9, 2026
…mall files (apache#59011) Related PR: apache#57770 Problem Summary: When merging small files with inverted indexes, the segment close operation was synchronously waiting for inverted index files to be uploaded to S3. This blocking behavior significantly impacted the memtable flush thread performance, causing bottlenecks in the data loading pipeline. Solution: The solution introduces a two-phase close mechanism for inverted index file writers: 1. **Asynchronous Close Phase**: During segment close, inverted index files are closed asynchronously and the S3 upload task is submitted immediately without waiting for completion. 2. **Wait Phase**: When the load channel closes, the system waits for all pending S3 upload tasks to complete, ensuring data consistency.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #xxx
Related PR: #57770
Problem Summary:
When merging small files with inverted indexes, the segment close operation was synchronously waiting for inverted index files to be uploaded to S3. This blocking behavior significantly impacted the memtable flush thread performance, causing bottlenecks in the data loading pipeline.
Solution:
The solution introduces a two-phase close mechanism for inverted index file writers:
Asynchronous Close Phase: During segment close, inverted index files are closed asynchronously and the S3 upload task is submitted immediately without waiting for completion.
Wait Phase: When the load channel closes, the system waits for all pending S3 upload tasks to complete, ensuring data consistency.
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)