Skip to content

[chore](dep)Remove hadoop-gcs dependencies #59063

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
CalvinKirs merged 1 commit into from
Dec 17, 2025
Merged

[chore](dep)Remove hadoop-gcs dependencies #59063

CalvinKirs merged 1 commit into from
Dec 17, 2025

Conversation

@CalvinKirs
Copy link
Member

@CalvinKirs CalvinKirs commented Dec 16, 2025

We access GCS through the S3-compatible API, so this dependency is unnecessary.

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@CalvinKirs
[chore](dep)Remove hadoop-gcs dependencies
93ce7e4 
We access GCS through the S3-compatible API, so this dependency is unnecessary.
@Thearas
Copy link
Contributor

Thearas commented Dec 16, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@CalvinKirs
Copy link
Member Author

CalvinKirs commented Dec 16, 2025

run buildall

@doris-robot
Copy link

doris-robot commented Dec 16, 2025

TPC-H: Total hot run time: 35046 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 93ce7e47b2fbfbb277a8bc239e91f2efccb7815d, data reload: false

------ Round 1 ----------------------------------
q1	17632	4292	4115	4115
q2	2015	345	233	233
q3	10194	1376	761	761
q4	10225	895	324	324
q5	7538	2173	1962	1962
q6	192	174	137	137
q7	1011	873	722	722
q8	9361	1494	1164	1164
q9	7057	5368	5329	5329
q10	6877	2376	1959	1959
q11	537	324	308	308
q12	652	736	584	584
q13	17800	3668	3056	3056
q14	285	294	270	270
q15	587	525	526	525
q16	696	679	634	634
q17	701	754	606	606
q18	7763	7042	6910	6910
q19	1082	958	624	624
q20	425	364	250	250
q21	4225	4011	3597	3597
q22	1044	984	976	976
Total cold run time: 107899 ms
Total hot run time: 35046 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4187	4089	4124	4089
q2	337	394	320	320
q3	2149	2692	2275	2275
q4	1329	1778	1304	1304
q5	4243	4593	4765	4593
q6	220	186	128	128
q7	2078	2031	1832	1832
q8	2682	2553	2562	2553
q9	7549	7518	7453	7453
q10	3040	3221	2829	2829
q11	626	527	498	498
q12	667	766	723	723
q13	3647	3954	3322	3322
q14	301	324	292	292
q15	576	520	513	513
q16	670	851	684	684
q17	1193	1461	1457	1457
q18	8003	7667	7661	7661
q19	920	886	892	886
q20	2028	1978	1809	1809
q21	4662	4274	4167	4167
q22	1073	1026	997	997
Total cold run time: 52180 ms
Total hot run time: 50385 ms

@doris-robot
Copy link

doris-robot commented Dec 16, 2025

TPC-DS: Total hot run time: 177856 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 93ce7e47b2fbfbb277a8bc239e91f2efccb7815d, data reload: false

query5	5105	638	477	477
query6	324	235	210	210
query7	4207	454	279	279
query8	306	244	236	236
query9	8756	2566	2565	2565
query10	499	373	342	342
query11	15178	14735	14528	14528
query12	171	126	117	117
query13	1247	471	381	381
query14	6185	3159	2995	2995
query14_1	2877	2881	2863	2863
query15	203	199	183	183
query16	830	474	455	455
query17	1096	676	568	568
query18	2556	430	335	335
query19	229	221	199	199
query20	124	112	108	108
query21	212	134	121	121
query22	3873	4029	3822	3822
query23	16423	16170	15884	15884
query23_1	16133	16144	15980	15980
query24	7359	1644	1214	1214
query24_1	1227	1231	1266	1231
query25	553	465	442	442
query26	1100	265	162	162
query27	2747	465	304	304
query28	4527	2129	2115	2115
query29	784	541	434	434
query30	313	242	213	213
query31	807	692	627	627
query32	74	69	66	66
query33	537	331	289	289
query34	891	902	538	538
query35	762	823	720	720
query36	844	903	827	827
query37	130	92	75	75
query38	2912	2911	2822	2822
query39	842	733	726	726
query39_1	708	769	692	692
query40	226	136	121	121
query41	65	63	64	63
query42	108	106	107	106
query43	434	430	419	419
query44	1328	755	747	747
query45	191	188	182	182
query46	884	976	626	626
query47	1632	1664	1624	1624
query48	315	325	241	241
query49	608	450	369	369
query50	642	294	220	220
query51	3880	3807	3832	3807
query52	114	112	100	100
query53	320	343	288	288
query54	282	262	244	244
query55	90	77	72	72
query56	287	302	300	300
query57	1159	1134	1052	1052
query58	282	258	241	241
query59	2346	2458	2328	2328
query60	309	310	279	279
query61	155	177	159	159
query62	709	665	615	615
query63	325	291	303	291
query64	4672	1364	1112	1112
query65	4034	3956	3940	3940
query66	1382	467	341	341
query67	15279	14797	14761	14761
query68	2804	1050	785	785
query69	449	364	316	316
query70	1026	991	952	952
query71	337	316	293	293
query72	6428	5173	5287	5173
query73	535	673	303	303
query74	8830	8773	8540	8540
query75	3076	3115	2756	2756
query76	2878	1122	738	738
query77	336	384	291	291
query78	9549	9727	8803	8803
query79	1283	865	624	624
query80	1217	648	557	557
query81	555	269	236	236
query82	541	134	104	104
query83	364	250	232	232
query84	261	116	98	98
query85	928	523	463	463
query86	389	323	302	302
query87	3061	3111	2918	2918
query88	3285	2327	2289	2289
query89	455	427	399	399
query90	1973	156	156	156
query91	176	164	147	147
query92	73	71	65	65
query93	1139	921	557	557
query94	528	303	291	291
query95	585	373	292	292
query96	603	460	206	206
query97	2261	2298	2256	2256
query98	212	193	193	193
query99	1294	1301	1223	1223
Total cold run time: 253140 ms
Total hot run time: 177856 ms

@doris-robot
Copy link

doris-robot commented Dec 16, 2025

ClickBench: Total hot run time: 27.29 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 93ce7e47b2fbfbb277a8bc239e91f2efccb7815d, data reload: false

query1	0.06	0.05	0.05
query2	0.10	0.05	0.05
query3	0.25	0.09	0.09
query4	1.62	0.11	0.11
query5	0.27	0.26	0.26
query6	1.18	0.64	0.63
query7	0.04	0.03	0.03
query8	0.06	0.04	0.04
query9	0.58	0.52	0.50
query10	0.55	0.55	0.56
query11	0.16	0.12	0.12
query12	0.16	0.11	0.11
query13	0.63	0.61	0.62
query14	0.98	0.98	0.99
query15	0.80	0.79	0.80
query16	0.40	0.39	0.40
query17	1.02	1.04	1.05
query18	0.23	0.22	0.21
query19	1.81	1.86	1.79
query20	0.02	0.01	0.01
query21	15.44	0.28	0.14
query22	4.92	0.05	0.05
query23	16.10	0.28	0.10
query24	1.88	0.29	0.46
query25	0.08	0.05	0.05
query26	0.14	0.14	0.14
query27	0.06	0.05	0.04
query28	4.60	1.22	1.02
query29	12.64	3.99	3.24
query30	0.27	0.14	0.12
query31	2.83	0.66	0.39
query32	3.23	0.54	0.46
query33	2.98	3.10	3.00
query34	16.82	5.15	4.52
query35	4.56	4.56	4.52
query36	0.66	0.50	0.49
query37	0.10	0.07	0.07
query38	0.06	0.04	0.04
query39	0.05	0.03	0.03
query40	0.17	0.14	0.14
query41	0.09	0.03	0.03
query42	0.04	0.02	0.02
query43	0.04	0.03	0.04
Total cold run time: 98.68 s
Total hot run time: 27.29 s

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Dec 16, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Dec 16, 2025

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 16, 2025

PR approved by anyone and no changes requested.

@hello-stephen
Copy link
Contributor

hello-stephen commented Dec 16, 2025

FE UT Coverage Report

Increment line coverage `` 🎉
Increment coverage report
Complete coverage report

@CalvinKirs CalvinKirs merged commit 8e30d70 into apache:master Dec 17, 2025
29 of 31 checks passed
@CalvinKirs CalvinKirs deleted the master-rm-gcs branch December 17, 2025 09:46
CalvinKirs added a commit to CalvinKirs/incubator-doris that referenced this pull request Jan 7, 2026
@CalvinKirs
branch-4.0: [Fix](catalog)Resources should be closed when dropping a …
68e5cbe 
…Catalog.

apache#59512
apache#59063
@CalvinKirs CalvinKirs mentioned this pull request Jan 7, 2026
Merged
16 tasks
yiguolei pushed a commit that referenced this pull request Jan 8, 2026
@CalvinKirs
branch-4.0: [Fix](catalog)Resources should be closed when dropping a …
aa5f28e 
…Catalog. (#59642)

…

#59512
#59063

### What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

### Release note

None

### Check List (For Author)

- Test <!-- At least one of them must be included. -->
    - [ ] Regression test
    - [ ] Unit Test
    - [ ] Manual test (add detailed scripts or steps below)
    - [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
        - [ ] Previous test can cover this change.
        - [ ] No code files have been changed.
        - [ ] Other reason <!-- Add your reason?  -->

- Behavior changed:
    - [ ] No.
    - [ ] Yes. <!-- Explain the behavior change -->

- Does this need documentation?
    - [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg:
apache/doris-website#1214 -->

### Check List (For Reviewer who merge this PR)

- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR
should merge into -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@morningman morningman morningman approved these changes

@zhangstar333 zhangstar333 zhangstar333 approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. dev/3.1.x dev/3.1.x-conflict dev/4.0.3-merged reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@CalvinKirs @Thearas @doris-robot @hello-stephen @morningman @zhangstar333 @yiguolei