Skip to content

branch-4.0: [opt](iceberg) able to ignore iceberg dangling delete to do count push down (#58889) #59068

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
morningman merged 1 commit into from
Dec 23, 2025
Merged

branch-4.0: [opt](iceberg) able to ignore iceberg dangling delete to do count push down (#58889) #59068

morningman merged 1 commit into from
Dec 23, 2025

Conversation

@morningman
Copy link
Contributor

@morningman morningman commented Dec 16, 2025

bp #58889

@morningman morningman requested a review from yiguolei as a code owner December 16, 2025 03:56
@hello-stephen
Copy link
Contributor

hello-stephen commented Dec 16, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@morningman
Copy link
Contributor Author

morningman commented Dec 16, 2025

run buildall

@morningman
[opt](iceberg) able to ignore iceberg dangling delete to do count pus…
44aab14 
…h down (apache#58889)

Related PR: apache#44039

Problem Summary:

In apache#44039, we disable the count push down to iceberg table if it has
position delete file,
because there may be dangling delete file that will cause the statistics
info incorrect.

This PR add a new session variable `ignore_iceberg_dangling_delete`,
default is false,
when set to true, Doris will ignore the dangling delete issue and do
count push down for iceberg table,
add user should take care of the result.
@morningman
Copy link
Contributor Author

morningman commented Dec 22, 2025

run buildall

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Dec 23, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Dec 23, 2025

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 23, 2025

PR approved by anyone and no changes requested.

@morningman morningman merged commit 97fa3b1 into apache:branch-4.0 Dec 23, 2025
23 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yiguolei yiguolei yiguolei approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@morningman @hello-stephen @yiguolei