Skip to content

[fix](predicate) Fix use-after-free caused by string predicate #59098

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
morningman merged 1 commit into from
Dec 17, 2025
Merged

[fix](predicate) Fix use-after-free caused by string predicate #59098

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 17 additions & 13 deletions be/src/olap/predicate_creator.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -218,24 +218,28 @@ std::shared_ptr<ColumnPredicate> create_comparison_predicate0(
}
case TYPE_CHAR: {
// TODO(gabriel): Use std::string instead of StringRef
size_t target = assert_cast<const vectorized::DataTypeString*>(
vectorized::remove_nullable(data_type).get())
->len();
StringRef v = value;
if (target > value.size) {
char* buffer = arena.alloc(target);
memset(buffer, 0, target);
memcpy(buffer, value.data, value.size);
v = {buffer, target};
}

auto target =
std::max(cast_set<size_t>(assert_cast<const vectorized::DataTypeString*>(
vectorized::remove_nullable(data_type).get())
->len()),
value.size);
char* buffer = arena.alloc(target);
memset(buffer, 0, target);
memcpy(buffer, value.data, value.size);
StringRef v = {buffer, target};
return ComparisonPredicateBase<TYPE_CHAR, PT>::create_shared(cid, v, opposite);
}
case TYPE_VARCHAR: {
return ComparisonPredicateBase<TYPE_VARCHAR, PT>::create_shared(cid, value, opposite);
char* buffer = arena.alloc(value.size);
memcpy(buffer, value.data, value.size);
StringRef v = {buffer, value.size};
return ComparisonPredicateBase<TYPE_VARCHAR, PT>::create_shared(cid, v, opposite);
}
case TYPE_STRING: {
return ComparisonPredicateBase<TYPE_STRING, PT>::create_shared(cid, value, opposite);
char* buffer = arena.alloc(value.size);
memcpy(buffer, value.data, value.size);
StringRef v = {buffer, value.size};
return ComparisonPredicateBase<TYPE_STRING, PT>::create_shared(cid, v, opposite);
}
case TYPE_DATE: {
return ComparisonPredicateBase<TYPE_DATE, PT>::create_shared(
Expand Down
Loading