[feature](function) Impl the function map_concat like spark #59130

nagisa-kunhah · 2025-12-17T18:59:48Z

Fix #51706

What problem does this PR solve?

Issue Number: close #xxx

Fix issue: #51706

Problem Summary:

Release note

None

Check List (For Author)

Test
- Regression test
- Unit Test
- Manual test (add detailed scripts or steps below)
- No need to test or manual test. Explain why:
  - This is a refactor/code format and no logic has been changed.
  - Previous test can cover this change.
  - No code files have been changed.
  - Other reason
Behavior changed:
- No.
- Yes.
Does this need documentation?
- No.
- Yes. [Feature](docs) Impl the function map_concat like spark doris-website#3220

Check List (For Reviewer who merge this PR)

Confirm the release note
Confirm test cases
Confirm document
Add branch pick label

hello-stephen · 2025-12-17T18:59:53Z

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

What problem was fixed (it's best to include specific error reporting information). How it was fixed.
Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
What features were added. Why was this function added?
Which code was refactored and why was this part of the code refactored?
Which functions were optimized and what is the difference before and after the optimization?

zclllyybb

LGTM

github-actions · 2026-01-17T20:25:53Z

PR approved by at least one committer and no changes requested.

zclllyybb · 2026-01-17T20:26:28Z

your new added BE-UT case failed. please check them.

nagisa-kunhah · 2026-01-18T15:12:34Z

run buildall

hello-stephen · 2026-01-18T16:21:23Z

FE UT Coverage Report

Increment line coverage 2.70% (1/37) 🎉
Increment coverage report
Complete coverage report

nagisa-kunhah · 2026-01-26T16:42:46Z

run buildall

hello-stephen · 2026-01-26T17:49:49Z

FE UT Coverage Report

Increment line coverage 2.70% (1/37) 🎉
Increment coverage report
Complete coverage report

doris-robot · 2026-01-26T18:18:43Z

TPC-H: Total hot run time: 32800 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 9dd20deb58ca39def26f44c685e0543aa1b955c4, data reload: false

------ Round 1 ----------------------------------
q1	17629	5310	5070	5070
q2	2031	320	236	236
q3	10153	1315	767	767
q4	10198	820	316	316
q5	7505	2165	1931	1931
q6	201	185	150	150
q7	892	732	608	608
q8	9263	1437	1116	1116
q9	5461	4854	4782	4782
q10	6864	1965	1555	1555
q11	507	294	286	286
q12	395	382	224	224
q13	17787	4052	3191	3191
q14	234	241	217	217
q15	913	839	823	823
q16	669	677	620	620
q17	644	886	422	422
q18	6763	6505	7552	6505
q19	1736	1049	645	645
q20	408	376	235	235
q21	2970	2322	2068	2068
q22	1215	1127	1033	1033
Total cold run time: 104438 ms
Total hot run time: 32800 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5665	5541	5435	5435
q2	263	350	270	270
q3	2381	2845	2568	2568
q4	1540	1929	1471	1471
q5	4793	4516	4432	4432
q6	228	189	138	138
q7	2021	1954	1915	1915
q8	2559	2359	2395	2359
q9	7595	7654	7449	7449
q10	2822	2956	2546	2546
q11	534	448	430	430
q12	611	725	558	558
q13	3542	3998	3262	3262
q14	270	278	264	264
q15	831	799	794	794
q16	633	672	627	627
q17	1068	1335	1367	1335
q18	7391	7323	7331	7323
q19	826	786	805	786
q20	1978	2066	1886	1886
q21	4525	4217	4083	4083
q22	1057	1072	990	990
Total cold run time: 53133 ms
Total hot run time: 50921 ms

doris-robot · 2026-01-26T18:35:30Z

ClickBench: Total hot run time: 28.24 s

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 9dd20deb58ca39def26f44c685e0543aa1b955c4, data reload: false

query1	0.05	0.04	0.05
query2	0.10	0.05	0.05
query3	0.26	0.09	0.09
query4	1.61	0.11	0.11
query5	0.27	0.24	0.25
query6	1.18	0.69	0.67
query7	0.04	0.03	0.02
query8	0.05	0.04	0.04
query9	0.56	0.51	0.50
query10	0.54	0.53	0.53
query11	0.14	0.09	0.10
query12	0.14	0.10	0.10
query13	0.63	0.61	0.61
query14	1.06	1.06	1.04
query15	0.88	0.87	0.86
query16	0.41	0.40	0.39
query17	1.07	1.12	1.09
query18	0.22	0.22	0.20
query19	2.14	2.00	1.94
query20	0.02	0.01	0.02
query21	15.42	0.24	0.14
query22	5.16	0.05	0.05
query23	15.87	0.28	0.11
query24	1.01	0.74	0.31
query25	0.07	0.09	0.06
query26	0.13	0.13	0.14
query27	0.07	0.05	0.07
query28	3.55	1.16	0.96
query29	12.60	3.90	3.17
query30	0.28	0.13	0.12
query31	2.83	0.62	0.40
query32	3.24	0.60	0.50
query33	3.19	3.28	3.21
query34	16.10	5.37	4.75
query35	4.81	4.78	4.78
query36	0.66	0.51	0.50
query37	0.13	0.07	0.07
query38	0.07	0.05	0.04
query39	0.04	0.03	0.03
query40	0.19	0.17	0.16
query41	0.09	0.04	0.03
query42	0.04	0.02	0.02
query43	0.04	0.04	0.03
Total cold run time: 96.96 s
Total hot run time: 28.24 s

doris-robot · 2026-01-26T19:51:04Z

BE UT Coverage Report

Increment line coverage 76.92% (50/65) 🎉

Increment coverage report
Complete coverage report

Category	Coverage
Function Coverage	52.48% (19146/36485)
Line Coverage	35.87% (177996/496209)
Region Coverage	32.32% (137496/425483)
Branch Coverage	33.26% (59535/178982)

hello-stephen · 2026-01-26T20:52:40Z

BE Regression && UT Coverage Report

Increment line coverage 86.15% (56/65) 🎉

Increment coverage report
Complete coverage report

Category	Coverage
Function Coverage	73.18% (26170/35762)
Line Coverage	56.22% (278672/495665)
Region Coverage	53.86% (231608/429988)
Branch Coverage	55.63% (100001/179750)

hello-stephen · 2026-01-26T21:03:07Z

FE Regression Coverage Report

Increment line coverage 81.08% (30/37) 🎉
Increment coverage report
Complete coverage report

nagisa-kunhah · 2026-01-28T18:00:48Z

run buildall

doris-robot · 2026-01-28T19:36:30Z

TPC-H: Total hot run time: 32119 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 6336b48e997499766c829b3bd25eb1b89ebaf81d, data reload: false

------ Round 1 ----------------------------------
q1	17655	5243	5881	5243
q2	2031	307	190	190
q3	10207	1284	734	734
q4	10202	809	317	317
q5	7505	2188	1917	1917
q6	220	179	147	147
q7	886	742	610	610
q8	9260	1396	1070	1070
q9	5338	4914	4885	4885
q10	6874	1966	1563	1563
q11	510	310	291	291
q12	397	383	223	223
q13	17805	4050	3254	3254
q14	248	239	216	216
q15	921	827	814	814
q16	695	693	640	640
q17	636	771	534	534
q18	7092	6615	6457	6457
q19	1465	983	596	596
q20	388	337	228	228
q21	2700	2088	1912	1912
q22	361	324	278	278
Total cold run time: 103396 ms
Total hot run time: 32119 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5397	5285	5326	5285
q2	253	343	259	259
q3	2153	2680	2268	2268
q4	1367	1756	1304	1304
q5	4273	4196	4199	4196
q6	235	254	207	207
q7	2219	1982	1995	1982
q8	2646	2455	2461	2455
q9	7458	7485	7503	7485
q10	2783	2998	2671	2671
q11	537	507	472	472
q12	697	742	586	586
q13	4121	4382	3756	3756
q14	301	303	286	286
q15	848	807	825	807
q16	677	747	696	696
q17	1163	1356	1356	1356
q18	8349	7942	8266	7942
q19	864	846	843	843
q20	2080	2239	1961	1961
q21	4789	4367	4179	4179
q22	630	550	528	528
Total cold run time: 53840 ms
Total hot run time: 51524 ms

doris-robot · 2026-01-28T19:53:17Z

ClickBench: Total hot run time: 28.62 s

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 6336b48e997499766c829b3bd25eb1b89ebaf81d, data reload: false

query1	0.06	0.05	0.04
query2	0.10	0.05	0.05
query3	0.26	0.09	0.08
query4	1.61	0.11	0.11
query5	0.27	0.25	0.25
query6	1.16	0.68	0.67
query7	0.03	0.02	0.03
query8	0.05	0.04	0.04
query9	0.58	0.50	0.49
query10	0.54	0.54	0.55
query11	0.14	0.10	0.09
query12	0.14	0.10	0.10
query13	0.64	0.61	0.61
query14	1.06	1.06	1.04
query15	0.88	0.86	0.87
query16	0.39	0.39	0.40
query17	1.15	1.12	1.15
query18	0.23	0.21	0.21
query19	2.11	1.95	2.00
query20	0.02	0.01	0.02
query21	15.41	0.25	0.14
query22	4.97	0.05	0.05
query23	15.92	0.29	0.11
query24	0.92	0.76	0.74
query25	0.11	0.07	0.10
query26	0.14	0.12	0.13
query27	0.10	0.05	0.04
query28	4.95	1.12	0.95
query29	12.65	3.86	3.15
query30	0.28	0.13	0.11
query31	2.83	0.65	0.42
query32	3.24	0.60	0.49
query33	3.30	3.29	3.26
query34	16.29	5.37	4.72
query35	4.82	4.76	4.73
query36	0.65	0.49	0.50
query37	0.11	0.07	0.07
query38	0.07	0.03	0.04
query39	0.04	0.04	0.03
query40	0.19	0.16	0.15
query41	0.09	0.03	0.03
query42	0.05	0.03	0.02
query43	0.06	0.04	0.03
Total cold run time: 98.61 s
Total hot run time: 28.62 s

doris-robot · 2026-01-28T21:05:04Z

BE UT Coverage Report

Increment line coverage 76.92% (50/65) 🎉

Increment coverage report
Complete coverage report

Category	Coverage
Function Coverage	52.73% (19263/36532)
Line Coverage	36.11% (179028/495729)
Region Coverage	32.55% (138818/426420)
Branch Coverage	33.50% (60089/179362)

hello-stephen · 2026-01-28T22:08:40Z

BE Regression && UT Coverage Report

Increment line coverage 86.15% (56/65) 🎉

Increment coverage report
Complete coverage report

Category	Coverage
Function Coverage	71.46% (25590/35810)
Line Coverage	54.07% (267380/494496)
Region Coverage	51.71% (222746/430738)
Branch Coverage	53.10% (95615/180078)

hello-stephen · 2026-01-28T22:19:40Z

FE Regression Coverage Report

Increment line coverage 81.08% (30/37) 🎉
Increment coverage report
Complete coverage report

github-actions · 2026-01-30T04:19:21Z

PR approved by at least one committer and no changes requested.

hello-stephen · 2026-01-30T04:26:24Z

BE Regression && UT Coverage Report

Increment line coverage 86.15% (56/65) 🎉

Increment coverage report
Complete coverage report

Category	Coverage
Function Coverage	71.45% (25587/35810)
Line Coverage	54.06% (267327/494496)
Region Coverage	51.67% (222575/430738)
Branch Coverage	53.08% (95584/180078)

hello-stephen · 2026-01-30T04:37:05Z

FE Regression Coverage Report

Increment line coverage 78.38% (29/37) 🎉
Increment coverage report
Complete coverage report

nagisa-kunhah added 25 commits December 15, 2025 02:13

feat: map_concat

106afda

fix: optimize code

eaddffe

fix: nullable

6473a03

feat: FunctionMapConcatTest

930ef85

fix: ColumnNullable

7b0bf75

feat: function_map_concat_test

f0970be

fix: function_map_concat_test

cef3520

remove: FunctionMapConcatTest.TestComplexTypes

e5c3bd8

fix: get_key_value_type

7869361

fix: TestComplexTypes of array

aea2e7f

fix: check_function_all_arg_comb

71a6cb7

feat: Test with double, float and decimalv2

d42447c

feat: Test single map

fc221f6

feat: extend map_concat to handle struct-typed values

053760a

fix: compile error

3c585c6

feat: test_map_concat

174cab1

fix: handle null values in arguments to prevent crash

65de5e5

fix: test_map_concat.out

d428f86

test: expand test coverage for mapconcat function

41c7f69

fix: style issue

4332c22

fix: stype issue

94bd981

fix: style issue

7bfec0f

fix: style issue

958eac9

fix: crash when “select map_concat();”

fb58202

fix: optimize test

109c9af

nagisa-kunhah requested a review from zclllyybb as a code owner December 17, 2025 18:59

zclllyybb self-assigned this Dec 17, 2025

fix: license issue

41ed41f

nagisa-kunhah changed the title ~~[feature] Impl the function map_concat like spark #51706~~ [feature](function) Impl the function map_concat like spark #51706 Dec 18, 2025

zclllyybb previously approved these changes Jan 17, 2026

View reviewed changes

github-actions bot added the approved Indicates a PR has been approved by one committer. label Jan 17, 2026

nagisa-kunhah and others added 2 commits January 18, 2026 20:31

Merge branch 'master' into feat_map_concat

42829ff

fix: ut

49bfdd6

nagisa-kunhah dismissed zclllyybb’s stale review via 49bfdd6 January 18, 2026 15:09

github-actions bot removed the approved Indicates a PR has been approved by one committer. label Jan 18, 2026

Merge branch 'master' into feat_map_concat

9dd20de

fix: format

6336b48

zclllyybb approved these changes Jan 30, 2026

View reviewed changes

github-actions bot added the approved Indicates a PR has been approved by one committer. label Jan 30, 2026

[feature](function) Impl the function map_concat like spark #59130

Are you sure you want to change the base?

[feature](function) Impl the function map_concat like spark #59130

Uh oh!

Conversation

nagisa-kunhah commented Dec 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What problem does this PR solve?

Release note

Check List (For Author)

Check List (For Reviewer who merge this PR)

Uh oh!

hello-stephen commented Dec 17, 2025

Uh oh!

zclllyybb left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Jan 17, 2026

Uh oh!

zclllyybb commented Jan 17, 2026

Uh oh!

nagisa-kunhah commented Jan 18, 2026

Uh oh!

hello-stephen commented Jan 18, 2026

FE UT Coverage Report

Uh oh!

nagisa-kunhah commented Jan 26, 2026

Uh oh!

hello-stephen commented Jan 26, 2026

FE UT Coverage Report

Uh oh!

doris-robot commented Jan 26, 2026

Uh oh!

doris-robot commented Jan 26, 2026

Uh oh!

doris-robot commented Jan 26, 2026

BE UT Coverage Report

Uh oh!

hello-stephen commented Jan 26, 2026

BE Regression && UT Coverage Report

Uh oh!

hello-stephen commented Jan 26, 2026

FE Regression Coverage Report

Uh oh!

nagisa-kunhah commented Jan 28, 2026

Uh oh!

doris-robot commented Jan 28, 2026

Uh oh!

doris-robot commented Jan 28, 2026

Uh oh!

doris-robot commented Jan 28, 2026

BE UT Coverage Report

Uh oh!

hello-stephen commented Jan 28, 2026

BE Regression && UT Coverage Report

Uh oh!

hello-stephen commented Jan 28, 2026

FE Regression Coverage Report

Uh oh!

github-actions bot commented Jan 30, 2026

Uh oh!

hello-stephen commented Jan 30, 2026

BE Regression && UT Coverage Report

Uh oh!

hello-stephen commented Jan 30, 2026

FE Regression Coverage Report

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

nagisa-kunhah commented Dec 17, 2025 •

edited

Loading