Skip to content

Conversation

@seawinde
Copy link
Contributor

What problem does this PR solve?

ConnectionContext maintains an aliveSessionSet in the Env class. The session ID associated with a ConnectionContext is only removed from this set when ConnectContext#cleanup() is explicitly called.

In certain scenarios—such as when a ConnectionContext is no longer in use—if only ConnectContext#remove() is invoked without calling ConnectContext#cleanup(), the session ID remains in Env#aliveSessionSet, causing it to grow indefinitely and eventually leading to a memory leak.

Therefore, whenever a ConnectionContext is confirmed to be no longer needed, ConnectContext#cleanup() must be called (e.g., in AutoCloseConnectContext#close()). On the other hand, if the ConnectionContext will still be used afterward, it's appropriate to call only ConnectContext#remove() (e.g., in AutoCloseSessionVariable).

This PR standardizes the usage of these methods across the codebase to prevent potential memory leaks.

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

…tContext#cleanup() is called when ConnectionContext is no longer in use
@Thearas
Copy link
Contributor

Thearas commented Dec 31, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@seawinde
Copy link
Contributor Author

run buildall

@hello-stephen
Copy link
Contributor

FE Regression Coverage Report

Increment line coverage 50.00% (4/8) 🎉
Increment coverage report
Complete coverage report

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants