[draft](connectionContext) Fix potential memory leak by ensuring ConnectContext#cleanup() is called when ConnectionContext is no longer in use #59510
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
ConnectionContext maintains an aliveSessionSet in the Env class. The session ID associated with a ConnectionContext is only removed from this set when ConnectContext#cleanup() is explicitly called.
In certain scenarios—such as when a ConnectionContext is no longer in use—if only ConnectContext#remove() is invoked without calling ConnectContext#cleanup(), the session ID remains in Env#aliveSessionSet, causing it to grow indefinitely and eventually leading to a memory leak.
Therefore, whenever a ConnectionContext is confirmed to be no longer needed, ConnectContext#cleanup() must be called (e.g., in AutoCloseConnectContext#close()). On the other hand, if the ConnectionContext will still be used afterward, it's appropriate to call only ConnectContext#remove() (e.g., in AutoCloseSessionVariable).
This PR standardizes the usage of these methods across the codebase to prevent potential memory leaks.
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)