Skip to content

[Feature](func) Support function QUANTILE_STATE_TO/FROM_BASE64 #59664

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
yiguolei merged 1 commit into from
Jan 12, 2026
Merged

[Feature](func) Support function QUANTILE_STATE_TO/FROM_BASE64 #59664

yiguolei merged 1 commit into from
Jan 12, 2026

Conversation

@linrrzqqq
Copy link
Contributor

@linrrzqqq linrrzqqq commented Jan 8, 2026 •
edited
Loading

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #59607

Problem Summary:

Release note

doc: apache/doris-website#3279
None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@linrrzqqq linrrzqqq requested a review from zclllyybb as a code owner January 8, 2026 02:58
@Thearas
Copy link
Contributor

Thearas commented Jan 8, 2026

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@linrrzqqq
Copy link
Contributor Author

linrrzqqq commented Jan 8, 2026

run buildall

@doris-robot
Copy link

doris-robot commented Jan 8, 2026

TPC-H: Total hot run time: 31910 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit daba7be27cd560671a7e3aae83dbd449c4494182, data reload: false

------ Round 1 ----------------------------------
q1	17610	4235	4037	4037
q2	2048	351	238	238
q3	10139	1274	704	704
q4	10206	808	322	322
q5	7552	2123	1805	1805
q6	185	172	141	141
q7	937	782	652	652
q8	9270	1352	1184	1184
q9	4825	4661	4655	4655
q10	6750	1806	1404	1404
q11	528	310	302	302
q12	676	753	592	592
q13	17794	3869	3122	3122
q14	293	309	280	280
q15	577	521	502	502
q16	687	674	628	628
q17	655	835	451	451
q18	6562	6385	6597	6385
q19	1205	1066	631	631
q20	443	411	267	267
q21	3350	2572	2548	2548
q22	1104	1101	1060	1060
Total cold run time: 103396 ms
Total hot run time: 31910 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4362	4341	4289	4289
q2	339	425	338	338
q3	2254	2818	2357	2357
q4	1457	1914	1448	1448
q5	4372	4279	4392	4279
q6	225	178	131	131
q7	1960	1946	1705	1705
q8	2504	2435	2488	2435
q9	7102	7119	7144	7119
q10	2464	2802	2333	2333
q11	573	487	456	456
q12	693	761	645	645
q13	3639	3998	3313	3313
q14	264	297	261	261
q15	524	485	486	485
q16	616	648	589	589
q17	1053	1229	1292	1229
q18	7594	7173	7306	7173
q19	828	795	766	766
q20	1916	1969	1845	1845
q21	4408	4292	4115	4115
q22	1090	1036	1012	1012
Total cold run time: 50237 ms
Total hot run time: 48323 ms

@doris-robot
Copy link

doris-robot commented Jan 8, 2026

TPC-DS: Total hot run time: 173760 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit daba7be27cd560671a7e3aae83dbd449c4494182, data reload: false

query5	4430	582	430	430
query6	346	221	201	201
query7	4214	447	264	264
query8	323	243	264	243
query9	8771	2646	2660	2646
query10	515	373	318	318
query11	15231	15046	14874	14874
query12	191	115	123	115
query13	1278	470	366	366
query14	6306	3005	2757	2757
query14_1	2701	2634	2658	2634
query15	204	195	178	178
query16	995	477	394	394
query17	1125	687	579	579
query18	2469	442	354	354
query19	232	226	204	204
query20	125	119	116	116
query21	224	148	126	126
query22	4092	4108	4014	4014
query23	16045	15668	15532	15532
query23_1	15436	15608	15632	15608
query24	7472	1544	1180	1180
query24_1	1179	1176	1179	1176
query25	571	485	418	418
query26	1236	264	162	162
query27	2752	457	292	292
query28	4530	2189	2151	2151
query29	742	517	438	438
query30	304	237	211	211
query31	916	628	535	535
query32	83	66	67	66
query33	546	331	282	282
query34	894	895	517	517
query35	722	751	665	665
query36	866	887	821	821
query37	133	94	75	75
query38	2718	2742	2713	2713
query39	770	747	717	717
query39_1	696	717	711	711
query40	219	131	114	114
query41	65	64	61	61
query42	104	101	101	101
query43	466	448	411	411
query44	1313	722	729	722
query45	186	181	178	178
query46	855	950	584	584
query47	1433	1509	1404	1404
query48	310	314	249	249
query49	599	447	320	320
query50	637	278	202	202
query51	3794	3831	3804	3804
query52	111	113	102	102
query53	293	325	267	267
query54	283	252	241	241
query55	77	78	72	72
query56	287	320	288	288
query57	1008	995	934	934
query58	268	252	249	249
query59	2083	2226	2158	2158
query60	312	311	292	292
query61	163	160	156	156
query62	380	359	309	309
query63	302	264	274	264
query64	4867	1300	995	995
query65	3701	3780	3786	3780
query66	1442	427	300	300
query67	15600	15301	15790	15301
query68	4153	951	721	721
query69	502	361	316	316
query70	1058	940	917	917
query71	359	297	279	279
query72	6071	3428	3593	3428
query73	751	695	299	299
query74	8818	8789	8610	8610
query75	2843	2816	2492	2492
query76	3923	1060	635	635
query77	532	371	274	274
query78	9604	9905	9138	9138
query79	988	899	581	581
query80	670	592	498	498
query81	497	269	233	233
query82	206	142	113	113
query83	264	248	240	240
query84	250	122	102	102
query85	893	514	462	462
query86	336	318	304	304
query87	2947	2870	2759	2759
query88	3085	2223	2228	2223
query89	386	356	338	338
query90	1963	149	150	149
query91	165	169	149	149
query92	74	67	63	63
query93	988	898	534	534
query94	572	310	291	291
query95	565	385	308	308
query96	576	452	201	201
query97	2326	2399	2322	2322
query98	243	213	201	201
query99	577	582	500	500
Total cold run time: 250191 ms
Total hot run time: 173760 ms

@doris-robot
Copy link

doris-robot commented Jan 8, 2026

ClickBench: Total hot run time: 27.02 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit daba7be27cd560671a7e3aae83dbd449c4494182, data reload: false

query1	0.06	0.04	0.04
query2	0.10	0.04	0.04
query3	0.25	0.08	0.08
query4	1.61	0.11	0.12
query5	0.26	0.28	0.26
query6	1.14	0.67	0.65
query7	0.04	0.03	0.03
query8	0.06	0.04	0.04
query9	0.56	0.50	0.50
query10	0.56	0.55	0.55
query11	0.15	0.10	0.10
query12	0.14	0.11	0.11
query13	0.59	0.58	0.59
query14	0.95	0.95	0.96
query15	0.80	0.76	0.79
query16	0.40	0.40	0.41
query17	1.06	1.02	1.09
query18	0.23	0.22	0.22
query19	1.94	1.92	1.88
query20	0.01	0.01	0.02
query21	15.44	0.28	0.14
query22	5.10	0.04	0.04
query23	15.92	0.28	0.10
query24	1.49	0.40	0.83
query25	0.13	0.08	0.07
query26	0.15	0.14	0.13
query27	0.07	0.05	0.05
query28	5.28	1.04	0.88
query29	12.58	3.97	3.15
query30	0.28	0.15	0.13
query31	2.82	0.64	0.40
query32	3.25	0.57	0.47
query33	3.00	3.04	3.01
query34	16.72	5.14	4.40
query35	4.48	4.47	4.47
query36	0.68	0.50	0.49
query37	0.10	0.07	0.06
query38	0.07	0.04	0.04
query39	0.05	0.03	0.03
query40	0.17	0.14	0.14
query41	0.09	0.04	0.03
query42	0.04	0.03	0.03
query43	0.04	0.03	0.03
Total cold run time: 98.86 s
Total hot run time: 27.02 s

@hello-stephen
Copy link
Contributor

hello-stephen commented Jan 8, 2026

FE Regression Coverage Report

Increment line coverage 90.48% (19/21) 🎉
Increment coverage report
Complete coverage report

2 similar comments
@hello-stephen
Copy link
Contributor

hello-stephen commented Jan 8, 2026

FE Regression Coverage Report

Increment line coverage 90.48% (19/21) 🎉
Increment coverage report
Complete coverage report

@hello-stephen
Copy link
Contributor

hello-stephen commented Jan 8, 2026

FE Regression Coverage Report

Increment line coverage 90.48% (19/21) 🎉
Increment coverage report
Complete coverage report

@hello-stephen
Copy link
Contributor

hello-stephen commented Jan 8, 2026

BE UT Coverage Report

Increment line coverage 42.53% (37/87) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 53.01% (18974/35794)
Line Coverage 39.08% (175836/449934)
Region Coverage 33.68% (136247/404516)
Branch Coverage 34.67% (58835/169708)

@hello-stephen
Copy link
Contributor

hello-stephen commented Jan 8, 2026

BE Regression && UT Coverage Report

Increment line coverage 95.40% (83/87) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 73.99% (25867/34960)
Line Coverage 61.39% (275234/448331)
Region Coverage 56.33% (230171/408625)
Branch Coverage 58.15% (98975/170212)

@hello-stephen
Copy link
Contributor

hello-stephen commented Jan 8, 2026

BE Regression && UT Coverage Report

Increment line coverage 95.40% (83/87) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 73.92% (25842/34960)
Line Coverage 61.27% (274673/448331)
Region Coverage 56.18% (229560/408625)
Branch Coverage 58.03% (98768/170212)

@hello-stephen
Copy link
Contributor

hello-stephen commented Jan 8, 2026

FE Regression Coverage Report

Increment line coverage 90.48% (19/21) 🎉
Increment coverage report
Complete coverage report

HappenLee
HappenLee approved these changes Jan 9, 2026
View reviewed changes
Copy link
Contributor

@HappenLee HappenLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jan 9, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Jan 9, 2026

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 9, 2026

PR approved by anyone and no changes requested.

@hello-stephen
Copy link
Contributor

hello-stephen commented Jan 9, 2026

BE Regression && UT Coverage Report

Increment line coverage 95.40% (83/87) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 73.92% (25841/34960)
Line Coverage 61.27% (274678/448331)
Region Coverage 56.17% (229545/408625)
Branch Coverage 58.03% (98767/170212)

@hello-stephen
Copy link
Contributor

hello-stephen commented Jan 9, 2026

FE Regression Coverage Report

Increment line coverage 71.43% (15/21) 🎉
Increment coverage report
Complete coverage report

@yiguolei yiguolei merged commit fea543c into apache:master Jan 12, 2026
33 of 34 checks passed
github-actions bot pushed a commit that referenced this pull request Jan 12, 2026
@linrrzqqq
[Feature](func) Support function QUANTILE_STATE_TO/FROM_BASE64 (#59664)
3f73212 
### What problem does this PR solve?

Issue Number: close #xxx

Related PR: #59607 

Problem Summary:

### Release note

None

### Check List (For Author)

- Test <!-- At least one of them must be included. -->
    - [x] Regression test
    - [ ] Unit Test
    - [ ] Manual test (add detailed scripts or steps below)
    - [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
        - [ ] Previous test can cover this change.
        - [ ] No code files have been changed.
        - [ ] Other reason <!-- Add your reason?  -->

- Behavior changed:
    - [ ] No.
    - [ ] Yes. <!-- Explain the behavior change -->

- Does this need documentation?
    - [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg:
apache/doris-website#1214 -->

### Check List (For Reviewer who merge this PR)

- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR
should merge into -->
@github-actions github-actions bot mentioned this pull request Jan 12, 2026
Merged
yiguolei pushed a commit that referenced this pull request Jan 13, 2026
@github-actions @linrrzqqq
branch-4.0: [Feature](func) Support function QUANTILE_STATE_TO/FROM_B…
396c093 
…ASE64 #59664 (#59746)

Cherry-picked from #59664

Co-authored-by: linrrarity <linzhenqi@selectdb.com>
@linrrzqqq linrrzqqq deleted the qts-mst branch January 13, 2026 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@HappenLee HappenLee HappenLee approved these changes

@zclllyybb zclllyybb zclllyybb approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. dev/2.1.x dev/3.0.x dev/3.1.x dev/3.1.x-conflict dev/4.0.3-merged reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@linrrzqqq @Thearas @doris-robot @hello-stephen @HappenLee @zclllyybb @yiguolei