Skip to content

Conversation

@hubgeter
Copy link
Contributor

@hubgeter hubgeter commented Jan 8, 2026

bp #57771

What problem does this PR solve?

Problem Summary:

  1. The previous page index could only handle SQL WHERE conditions that only contained AND, but this PR can handle conditions that contain OR.
  2. Because the topn runtime filter is dynamically maintained, this PR delays the timing of the topn RF min-max filter until the row group reader is created.

…r parquet page index. (apache#57771)

Problem Summary:
1. The previous page index could only handle SQL WHERE conditions that
only contained AND, but this PR can handle conditions that contain OR.
2. Because the topn runtime filter is dynamically maintained, this PR
delays the timing of the topn RF min-max filter until the row group
reader is created.
@hubgeter hubgeter requested a review from yiguolei as a code owner January 8, 2026 10:20
@hello-stephen
Copy link
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@hubgeter
Copy link
Contributor Author

hubgeter commented Jan 8, 2026

run buildall

@hubgeter
Copy link
Contributor Author

hubgeter commented Jan 8, 2026

run buildall

@hubgeter
Copy link
Contributor Author

hubgeter commented Jan 9, 2026

run buildall

@hubgeter
Copy link
Contributor Author

hubgeter commented Jan 9, 2026

run buildall

@doris-robot
Copy link

BE UT Coverage Report

Increment line coverage 35.96% (146/406) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 53.28% (18687/35070)
Line Coverage 39.02% (172695/442540)
Region Coverage 33.74% (133561/395879)
Branch Coverage 34.72% (57778/166430)

@github-actions
Copy link
Contributor

github-actions bot commented Jan 9, 2026

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added approved Indicates a PR has been approved by one committer. reviewed labels Jan 9, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Jan 9, 2026

PR approved by anyone and no changes requested.

@yiguolei yiguolei merged commit 0221a73 into apache:branch-4.0 Jan 9, 2026
23 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants