Skip to content

Conversation

@morningman
Copy link
Contributor

@morningman morningman commented Jan 8, 2026

What problem does this PR solve?

Use memcpy_inline instead of memcpy
Before:

mysql> select count(ss_sold_date_sk), count(ss_customer_sk), count(ss_net_paid) from store_sales;
+------------------------+-----------------------+--------------------+
| count(ss_sold_date_sk) | count(ss_customer_sk) | count(ss_net_paid) |
+------------------------+-----------------------+--------------------+
|             2750387156 |            2750397233 |         2750388592 |
+------------------------+-----------------------+--------------------+
1 row in set (1.87 sec)

After:

mysql> select count(ss_sold_date_sk), count(ss_customer_sk), count(ss_net_paid) from store_sales;
+------------------------+-----------------------+--------------------+
| count(ss_sold_date_sk) | count(ss_customer_sk) | count(ss_net_paid) |
+------------------------+-----------------------+--------------------+
|             2750387156 |            2750397233 |         2750388592 |
+------------------------+-----------------------+--------------------+
1 row in set (1.79 sec)

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@Thearas
Copy link
Contributor

Thearas commented Jan 8, 2026

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@morningman
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 31947 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 0fe67a228d68ad846226bf5ea08f7a7066fc16de, data reload: false

------ Round 1 ----------------------------------
q1	17650	4371	4037	4037
q2	2016	388	244	244
q3	10141	1254	713	713
q4	10217	866	314	314
q5	7500	2082	1835	1835
q6	188	167	139	139
q7	929	802	675	675
q8	9268	1411	1139	1139
q9	4859	4569	4556	4556
q10	6744	1808	1399	1399
q11	492	293	276	276
q12	670	725	600	600
q13	17782	3826	3048	3048
q14	308	300	274	274
q15	587	513	515	513
q16	674	691	641	641
q17	678	770	538	538
q18	6623	6539	6770	6539
q19	1279	1086	633	633
q20	442	395	284	284
q21	3191	2648	2534	2534
q22	1136	1090	1016	1016
Total cold run time: 103374 ms
Total hot run time: 31947 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4308	4410	4237	4237
q2	322	407	321	321
q3	2294	2798	2404	2404
q4	1451	1821	1435	1435
q5	4461	4286	4223	4223
q6	214	172	124	124
q7	1969	1917	1726	1726
q8	2561	2459	2480	2459
q9	7004	7284	7259	7259
q10	2528	2718	2298	2298
q11	539	468	444	444
q12	722	770	610	610
q13	3538	4098	3286	3286
q14	269	290	267	267
q15	529	490	482	482
q16	597	636	621	621
q17	1094	1247	1299	1247
q18	7460	7443	7347	7347
q19	827	793	777	777
q20	1897	2009	1850	1850
q21	4484	4244	4069	4069
q22	1111	1030	971	971
Total cold run time: 50179 ms
Total hot run time: 48457 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 173002 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 0fe67a228d68ad846226bf5ea08f7a7066fc16de, data reload: false

query5	4477	583	415	415
query6	323	218	222	218
query7	4230	468	272	272
query8	331	254	246	246
query9	8812	2684	2672	2672
query10	527	378	324	324
query11	15223	15103	14912	14912
query12	175	114	112	112
query13	1260	491	377	377
query14	6439	2970	2704	2704
query14_1	2646	2579	2604	2579
query15	193	188	175	175
query16	1005	469	438	438
query17	1078	649	552	552
query18	2577	429	322	322
query19	224	221	188	188
query20	125	113	112	112
query21	211	141	117	117
query22	4272	4241	4002	4002
query23	16089	15800	15509	15509
query23_1	15402	15531	15501	15501
query24	7396	1543	1146	1146
query24_1	1194	1165	1211	1165
query25	537	454	414	414
query26	1239	270	172	172
query27	2744	457	288	288
query28	4560	2152	2145	2145
query29	830	596	438	438
query30	303	239	214	214
query31	830	632	549	549
query32	75	72	65	65
query33	530	329	288	288
query34	928	884	520	520
query35	717	744	674	674
query36	846	875	841	841
query37	130	93	81	81
query38	2789	2794	2678	2678
query39	763	757	752	752
query39_1	742	714	703	703
query40	215	131	112	112
query41	68	63	65	63
query42	104	103	100	100
query43	424	474	452	452
query44	1351	718	720	718
query45	183	186	174	174
query46	847	960	591	591
query47	1457	1480	1404	1404
query48	309	332	238	238
query49	607	411	331	331
query50	649	283	213	213
query51	3866	3885	3740	3740
query52	101	109	100	100
query53	299	322	266	266
query54	279	256	243	243
query55	78	74	76	74
query56	283	284	274	274
query57	1061	1012	929	929
query58	260	283	254	254
query59	2129	2200	2004	2004
query60	319	311	295	295
query61	167	158	157	157
query62	398	366	331	331
query63	299	267	265	265
query64	4937	1290	983	983
query65	3758	3745	3735	3735
query66	1401	420	295	295
query67	15009	14687	15122	14687
query68	2782	1017	736	736
query69	443	354	313	313
query70	1011	972	916	916
query71	315	299	277	277
query72	5638	3566	3716	3566
query73	584	730	312	312
query74	8830	8872	8598	8598
query75	2794	2815	2472	2472
query76	2939	1070	646	646
query77	357	384	293	293
query78	9851	9984	9223	9223
query79	1120	919	584	584
query80	1494	575	467	467
query81	550	265	230	230
query82	996	137	114	114
query83	348	256	238	238
query84	250	124	102	102
query85	1164	531	465	465
query86	422	319	324	319
query87	2925	2868	2748	2748
query88	3214	2236	2189	2189
query89	381	361	334	334
query90	1909	155	146	146
query91	172	167	140	140
query92	71	67	65	65
query93	1120	921	535	535
query94	653	321	290	290
query95	554	325	296	296
query96	579	458	204	204
query97	2342	2377	2313	2313
query98	206	213	197	197
query99	613	564	517	517
Total cold run time: 249424 ms
Total hot run time: 173002 ms

@morningman
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 31705 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 0e3b4c34f378c925f070f30c50cb116f890b6daf, data reload: false

------ Round 1 ----------------------------------
q1	17607	4214	4048	4048
q2	2028	344	236	236
q3	10154	1307	713	713
q4	10185	762	299	299
q5	7516	2096	1796	1796
q6	188	172	141	141
q7	911	792	649	649
q8	9272	1334	1075	1075
q9	4893	4521	4569	4521
q10	6779	1801	1392	1392
q11	541	303	279	279
q12	679	745	605	605
q13	17779	3800	3093	3093
q14	295	297	283	283
q15	579	513	512	512
q16	677	678	638	638
q17	635	801	493	493
q18	6540	6442	6727	6442
q19	1189	1067	676	676
q20	418	386	284	284
q21	3246	2636	2489	2489
q22	1163	1088	1041	1041
Total cold run time: 103274 ms
Total hot run time: 31705 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4399	4327	4299	4299
q2	332	416	343	343
q3	2248	2812	2427	2427
q4	1498	1956	1384	1384
q5	4657	4373	4292	4292
q6	210	164	130	130
q7	1935	1839	1748	1748
q8	2650	2503	2382	2382
q9	7728	7178	7369	7178
q10	2500	2751	2480	2480
q11	551	469	469	469
q12	725	787	673	673
q13	3718	3916	3136	3136
q14	269	289	271	271
q15	524	492	487	487
q16	655	659	635	635
q17	1143	1369	1319	1319
q18	7358	7235	7113	7113
q19	817	772	770	770
q20	1912	1945	1782	1782
q21	4487	4216	4207	4207
q22	1054	1021	972	972
Total cold run time: 51370 ms
Total hot run time: 48497 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 173368 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 0e3b4c34f378c925f070f30c50cb116f890b6daf, data reload: false

query5	4487	632	480	480
query6	340	248	219	219
query7	4243	453	258	258
query8	352	252	254	252
query9	8710	2881	2869	2869
query10	537	379	324	324
query11	15207	15117	14837	14837
query12	173	114	112	112
query13	1248	492	399	399
query14	6142	2999	2794	2794
query14_1	2686	2644	2682	2644
query15	202	187	175	175
query16	987	474	464	464
query17	1099	666	554	554
query18	2484	430	339	339
query19	222	214	197	197
query20	122	112	111	111
query21	218	139	120	120
query22	4187	4039	3811	3811
query23	15930	15508	15217	15217
query23_1	15426	15461	15362	15362
query24	7132	1531	1151	1151
query24_1	1172	1151	1163	1151
query25	545	450	411	411
query26	1246	266	156	156
query27	2767	444	282	282
query28	4544	2169	2164	2164
query29	750	571	403	403
query30	312	226	201	201
query31	816	613	544	544
query32	86	77	72	72
query33	520	347	307	307
query34	909	867	544	544
query35	709	743	676	676
query36	883	903	841	841
query37	129	95	82	82
query38	2744	2720	2620	2620
query39	780	742	714	714
query39_1	715	731	718	718
query40	219	133	114	114
query41	64	63	64	63
query42	102	95	98	95
query43	457	488	406	406
query44	1317	749	739	739
query45	182	181	174	174
query46	840	947	589	589
query47	1382	1524	1388	1388
query48	307	321	256	256
query49	599	419	336	336
query50	606	258	199	199
query51	3841	3809	3729	3729
query52	101	115	95	95
query53	309	327	274	274
query54	293	276	262	262
query55	82	81	74	74
query56	299	316	304	304
query57	1021	1034	959	959
query58	272	254	252	252
query59	2004	2048	2115	2048
query60	334	327	311	311
query61	173	147	140	140
query62	388	367	305	305
query63	290	265	258	258
query64	4822	1235	941	941
query65	3831	3750	3742	3742
query66	1452	415	319	319
query67	15528	15596	15403	15403
query68	2432	1098	757	757
query69	459	360	321	321
query70	1007	909	949	909
query71	317	303	285	285
query72	5244	3032	3157	3032
query73	564	662	308	308
query74	8745	8778	8568	8568
query75	2733	2813	2427	2427
query76	2258	1054	657	657
query77	338	372	286	286
query78	9663	9983	9114	9114
query79	1060	932	588	588
query80	636	569	483	483
query81	503	266	234	234
query82	1338	151	110	110
query83	373	266	250	250
query84	257	115	98	98
query85	900	550	519	519
query86	345	294	263	263
query87	2834	2813	2790	2790
query88	3467	2597	2578	2578
query89	383	335	332	332
query90	1913	165	156	156
query91	168	152	130	130
query92	74	72	69	69
query93	926	886	539	539
query94	445	325	288	288
query95	580	388	309	309
query96	648	509	224	224
query97	2349	2374	2304	2304
query98	212	202	215	202
query99	625	590	521	521
Total cold run time: 245941 ms
Total hot run time: 173368 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 26.87 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 0e3b4c34f378c925f070f30c50cb116f890b6daf, data reload: false

query1	0.05	0.06	0.05
query2	0.10	0.04	0.04
query3	0.26	0.08	0.08
query4	1.60	0.12	0.11
query5	0.28	0.26	0.25
query6	1.14	0.66	0.67
query7	0.04	0.02	0.03
query8	0.04	0.04	0.04
query9	0.57	0.51	0.50
query10	0.55	0.56	0.54
query11	0.14	0.10	0.10
query12	0.15	0.11	0.11
query13	0.59	0.58	0.60
query14	0.93	0.94	0.94
query15	0.79	0.77	0.78
query16	0.38	0.39	0.39
query17	1.06	1.04	1.04
query18	0.23	0.22	0.21
query19	1.94	1.89	1.88
query20	0.01	0.02	0.01
query21	15.44	0.28	0.13
query22	5.15	0.06	0.05
query23	15.95	0.27	0.10
query24	1.47	0.67	0.29
query25	0.11	0.06	0.07
query26	0.14	0.13	0.13
query27	0.09	0.06	0.05
query28	4.82	1.05	0.88
query29	12.55	3.94	3.15
query30	0.27	0.14	0.11
query31	2.82	0.63	0.40
query32	3.23	0.56	0.46
query33	2.95	3.06	3.06
query34	16.15	5.14	4.43
query35	4.40	4.42	4.47
query36	0.66	0.52	0.48
query37	0.10	0.06	0.06
query38	0.08	0.04	0.04
query39	0.04	0.03	0.04
query40	0.17	0.14	0.14
query41	0.09	0.03	0.02
query42	0.04	0.03	0.03
query43	0.04	0.04	0.03
Total cold run time: 97.61 s
Total hot run time: 26.87 s

@hello-stephen
Copy link
Contributor

BE UT Coverage Report

Increment line coverage 100.00% (25/25) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 52.39% (19030/36323)
Line Coverage 35.72% (176371/493761)
Region Coverage 32.27% (136623/423352)
Branch Coverage 33.15% (59030/178065)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants