-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[opt](fe) modify TabletInvertedIndex to local and cloud to reduce memory #59683
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1,046 changes: 1,046 additions & 0 deletions
1,046
fe/fe-core/src/main/java/org/apache/doris/catalog/LocalTabletInvertedIndex.java
Large diffs are not rendered by default.
Oops, something went wrong.
1,003 changes: 31 additions & 972 deletions
1,003
fe/fe-core/src/main/java/org/apache/doris/catalog/TabletInvertedIndex.java
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
133 changes: 133 additions & 0 deletions
133
fe/fe-core/src/main/java/org/apache/doris/cloud/catalog/CloudTabletInvertedIndex.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,133 @@ | ||
| // Licensed to the Apache Software Foundation (ASF) under one | ||
| // or more contributor license agreements. See the NOTICE file | ||
| // distributed with this work for additional information | ||
| // regarding copyright ownership. The ASF licenses this file | ||
| // to you under the Apache License, Version 2.0 (the | ||
| // "License"); you may not use this file except in compliance | ||
| // with the License. You may obtain a copy of the License at | ||
| // | ||
| // http://www.apache.org/licenses/LICENSE-2.0 | ||
| // | ||
| // Unless required by applicable law or agreed to in writing, | ||
| // software distributed under the License is distributed on an | ||
| // "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| // KIND, either express or implied. See the License for the | ||
| // specific language governing permissions and limitations | ||
| // under the License. | ||
|
|
||
| package org.apache.doris.cloud.catalog; | ||
|
|
||
| import org.apache.doris.catalog.Replica; | ||
| import org.apache.doris.catalog.TabletInvertedIndex; | ||
|
|
||
| import com.google.common.base.Preconditions; | ||
| import com.google.common.collect.Lists; | ||
| import com.google.common.collect.Maps; | ||
| import org.apache.logging.log4j.LogManager; | ||
| import org.apache.logging.log4j.Logger; | ||
|
|
||
| import java.util.List; | ||
| import java.util.Map; | ||
|
|
||
| public class CloudTabletInvertedIndex extends TabletInvertedIndex { | ||
| private static final Logger LOG = LogManager.getLogger(CloudTabletInvertedIndex.class); | ||
|
|
||
| // tablet id -> replica | ||
| // for cloud mode, no need to know the replica's backend | ||
| private Map<Long, Replica> replicaMetaMap = Maps.newHashMap(); | ||
|
|
||
| public CloudTabletInvertedIndex() { | ||
| super(); | ||
| } | ||
|
|
||
| @Override | ||
| public List<Replica> getReplicas(Long tabletId) { | ||
| long stamp = readLock(); | ||
| try { | ||
| if (replicaMetaMap.containsKey(tabletId)) { | ||
| return Lists.newArrayList(replicaMetaMap.get(tabletId)); | ||
| } | ||
| return Lists.newArrayList(); | ||
| } finally { | ||
| readUnlock(stamp); | ||
| } | ||
| } | ||
|
|
||
| @Override | ||
| public void deleteTablet(long tabletId) { | ||
| long stamp = writeLock(); | ||
| try { | ||
| replicaMetaMap.remove(tabletId); | ||
| tabletMetaMap.remove(tabletId); | ||
| if (LOG.isDebugEnabled()) { | ||
| LOG.debug("delete tablet: {}", tabletId); | ||
| } | ||
| } finally { | ||
| writeUnlock(stamp); | ||
| } | ||
| } | ||
|
|
||
| @Override | ||
| public void addReplica(long tabletId, Replica replica) { | ||
| long stamp = writeLock(); | ||
| try { | ||
| Preconditions.checkState(tabletMetaMap.containsKey(tabletId), | ||
| "tablet " + tabletId + " not exists, replica " + replica.getId()); | ||
| replicaMetaMap.put(tabletId, replica); | ||
| if (LOG.isDebugEnabled()) { | ||
| LOG.debug("add replica {} of tablet {}", replica.getId(), tabletId); | ||
| } | ||
| } finally { | ||
| writeUnlock(stamp); | ||
| } | ||
| } | ||
|
|
||
| @Override | ||
| public void deleteReplica(long tabletId, long backendId) { | ||
| long stamp = writeLock(); | ||
| try { | ||
| Preconditions.checkState(tabletMetaMap.containsKey(tabletId), "tablet " + tabletId + " not exists"); | ||
| if (replicaMetaMap.containsKey(tabletId)) { | ||
| Replica replica = replicaMetaMap.remove(tabletId); | ||
| if (LOG.isDebugEnabled()) { | ||
| LOG.debug("delete replica {} of tablet {}", replica.getId(), tabletId); | ||
| } | ||
| } else { | ||
| // this may happen when fe restart after tablet is empty(bug cause) | ||
| // add log instead of assertion to observe | ||
| LOG.error("tablet[{}] contains no replica in inverted index", tabletId); | ||
| } | ||
| } finally { | ||
| writeUnlock(stamp); | ||
| } | ||
| } | ||
|
|
||
mymeiyi marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| @Override | ||
| public Replica getReplica(long tabletId, long backendId) { | ||
| long stamp = readLock(); | ||
| try { | ||
| Preconditions.checkState(tabletMetaMap.containsKey(tabletId), "tablet " + tabletId + " not exists"); | ||
| return replicaMetaMap.get(tabletId); | ||
| } finally { | ||
| readUnlock(stamp); | ||
| } | ||
| } | ||
|
|
||
| @Override | ||
| public List<Replica> getReplicasByTabletId(long tabletId) { | ||
| long stamp = readLock(); | ||
| try { | ||
| if (replicaMetaMap.containsKey(tabletId)) { | ||
| return Lists.newArrayList(replicaMetaMap.get(tabletId)); | ||
| } | ||
| return Lists.newArrayList(); | ||
| } finally { | ||
| readUnlock(stamp); | ||
| } | ||
| } | ||
|
|
||
| @Override | ||
| protected void innerClear() { | ||
| replicaMetaMap.clear(); | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.