[Bug](runtime-filter) use rf_lock to lock local_state.conjuncts read operator #59688
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Currently, the reading and writing of conjuncts are not using the same lock, which may cause errors when reading conjuncts during vector expansion.
This pull request refactors how conjunct contexts are cloned in the scan operator pipeline. The main change is moving the responsibility for cloning conjunct contexts from the
ScanLocalStateclass to theRuntimeFilterConsumerHelperclass, simplifying the interface and improving encapsulation.Refactoring and responsibility shift:
clone_conjunct_ctxsmethod fromScanLocalStateand its base class, along with related members such as_conjunct_lock. This simplifies the scan local state classes and reduces their responsibilities. [1] [2] [3] [4]clone_conjunct_ctxsmethod toRuntimeFilterConsumerHelper, which now handles cloning of conjunct contexts, including locking and context management. [1] [2]Integration and usage updates:
Scanner::try_append_late_arrival_runtime_filtermethod to use the newclone_conjunct_ctxsmethod fromRuntimeFilterConsumerHelperinstead of the previous approach.Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)