[enhancement](cloud) improve FE RPC retry and MetaService connection handling #59698
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…handling Add address-provider retry path in ThriftRpcHelper; stream load uses provider to retry on new FE master Only reconnect MetaServiceProxy on request failures; close connection on getVisibleVersionAsync failure Update meta_service_rpc_reconnect_interval_ms in FE/BE (5000 -> 100)
luwei16
requested review from
dataroaring,
gavinchou and
w41ter
as code owners
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
Author
|
run buildall |
gavinchou
reviewed
Jan 8, 2026
| } | ||
| if (retry_address.hostname != address.hostname || retry_address.port != address.port) { | ||
| #ifndef ADDRESS_SANITIZER | ||
| LOG(INFO) << "retrying call frontend service with new address=" << retry_address; |
Contributor
There was a problem hiding this comment.
why not just log without check ifndef address?
gavinchou
reviewed
Jan 8, 2026
| timeout_ms, &retry_status); | ||
| if (!retry_status.ok()) { | ||
| #ifndef ADDRESS_SANITIZER | ||
| LOG(WARNING) << "Connect frontend failed, address=" << retry_address |
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
Contributor
FE UT Coverage ReportIncrement line coverage |
github-actions
bot
removed
the
approved
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 31600 ms |
TPC-DS: Total hot run time: 173604 ms |
gavinchou
approved these changes
Jan 9, 2026
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
skip check_coverage |
zzzxl1993
pushed a commit
to zzzxl1993/doris
that referenced
this pull request
Jan 13, 2026
…handling (apache#59698) Add address-provider retry path in ThriftRpcHelper and stream load uses provider to retry on new FE master Only reconnect MetaServiceProxy on request failures Update meta_service_rpc_reconnect_interval_ms in FE/BE (5000 -> 100)
github-actions bot
pushed a commit
that referenced
this pull request
Jan 13, 2026
…handling (#59698) Add address-provider retry path in ThriftRpcHelper and stream load uses provider to retry on new FE master Only reconnect MetaServiceProxy on request failures Update meta_service_rpc_reconnect_interval_ms in FE/BE (5000 -> 100)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add address-provider retry path in ThriftRpcHelper; stream load uses provider to retry on new FE master Only reconnect MetaServiceProxy on request failures; close connection on getVisibleVersionAsync failure Update meta_service_rpc_reconnect_interval_ms in FE/BE (5000 -> 100)