[fix](cloud) Fix memory leak in CloudTxnDeleteBitmapCache for empty rowsets #59710
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
liaoxin01
force-pushed
the
fix-empty-rowset-delete-bitmap-cache-leak-master
branch
2 times, most recently
from
9d55040 to
1cd2f1c
Compare
There was a problem hiding this comment.
Pull request overview
This PR fixes a memory leak in CloudTxnDeleteBitmapCache when handling empty rowsets with skip_writing_empty_rowset_metadata enabled. Previously, empty rowsets either stored full rowset info (causing memory leaks) or were skipped entirely (causing NOT_FOUND errors). The fix introduces a lightweight marker mechanism using only ~16 bytes per empty rowset.
Key changes:
- Introduced
_empty_rowset_markersset to track empty rowsets with minimal memory overhead - Added
mark_empty_rowset()andis_empty_rowset()methods for marker management - Modified cleanup logic to handle both regular txn entries and empty rowset markers
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| be/src/cloud/cloud_txn_delete_bitmap_cache.h | Added new methods and member variable for empty rowset marker tracking |
| be/src/cloud/cloud_txn_delete_bitmap_cache.cpp | Implemented marker methods and updated cleanup logic to handle markers |
| be/src/cloud/cloud_rowset_builder.cpp | Modified to call mark_empty_rowset for empty rowsets instead of storing full info |
| be/src/cloud/cloud_engine_calc_delete_bitmap_task.cpp | Added check for empty rowset markers to skip calculation gracefully |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
gavinchou
reviewed
Jan 9, 2026
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
…owsets When skip_writing_empty_rowset_metadata is enabled, empty rowsets are not committed to meta-service. Previously, set_txn_related_delete_bitmap() would either: 1. Store full rowset info in cache (causing memory leak since sync_tablet_delete_bitmap_by_cache() never cleans it up), or 2. Skip storing entirely (causing CalcDeleteBitmapTask to fail with NOT_FOUND error) This fix introduces a lightweight marker mechanism: - For empty rowsets, store only a TxnKey marker (~16 bytes) instead of full rowset info - CalcDeleteBitmapTask checks for marker via is_empty_rowset() and returns success if found (marker is NOT removed to support task retry) - Cleanup is handled by expiration-based removal in remove_expired_tablet_txn_info() - Expiration time is consistent with set_tablet_txn_info()
liaoxin01
force-pushed
the
fix-empty-rowset-delete-bitmap-cache-leak-master
branch
from
1cd2f1c to
2363e19
Compare
Contributor
Author
|
run buildall |
github-actions
bot
removed
the
approved
TPC-H: Total hot run time: 31408 ms |
TPC-DS: Total hot run time: 173119 ms |
bobhan1
approved these changes
Jan 9, 2026
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 32202 ms |
TPC-DS: Total hot run time: 172709 ms |
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 32074 ms |
TPC-DS: Total hot run time: 171672 ms |
Contributor
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
luwei16
approved these changes
Jan 13, 2026
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
gavinchou
approved these changes
Jan 13, 2026
liaoxin01
deleted the
fix-empty-rowset-delete-bitmap-cache-leak-master
branch
github-actions bot
pushed a commit
that referenced
this pull request
Jan 13, 2026
…owsets (#59710) ### What problem does this PR solve? Related PR: #54395 Problem Summary: When skip_writing_empty_rowset_metadata is enabled, empty rowsets are not committed to meta-service. Previously, set_txn_related_delete_bitmap() would either: 1. Store full rowset info in cache (causing memory leak since sync_tablet_delete_bitmap_by_cache() never cleans it up), or 2. Skip storing entirely (causing CalcDeleteBitmapTask to fail with NOT_FOUND error) This fix introduces a lightweight marker mechanism: - For empty rowsets, store only a TxnKey marker (~16 bytes) instead of full rowset info - CalcDeleteBitmapTask checks for marker via is_empty_rowset() and returns success if found (marker is NOT removed to support task retry) - Cleanup is handled by expiration-based removal in remove_expired_tablet_txn_info() - Expiration time is consistent with set_tablet_txn_info()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #xxx
Related PR: #54395
Problem Summary:
When skip_writing_empty_rowset_metadata is enabled, empty rowsets are not committed to meta-service. Previously, set_txn_related_delete_bitmap() would either:
This fix introduces a lightweight marker mechanism:
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)