-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[refactor](type) type checking in field #59733
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
80d6da2 to
fc8483d
Compare
|
run buildall |
|
run buildall |
|
run buildall |
|
run buildall |
|
run buildall |
|
run buildall |
|
run buildall |
TPC-H: Total hot run time: 31468 ms |
TPC-DS: Total hot run time: 172215 ms |
|
run buildall |
TPC-H: Total hot run time: 31583 ms |
TPC-DS: Total hot run time: 173143 ms |
|
run buildall |
TPC-H: Total hot run time: 31733 ms |
TPC-DS: Total hot run time: 171866 ms |
|
run buildall |
TPC-H: Total hot run time: 31585 ms |
TPC-DS: Total hot run time: 173653 ms |
|
run buildall |
TPC-H: Total hot run time: 31600 ms |
TPC-DS: Total hot run time: 172639 ms |
|
run buildall |
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
TPC-H: Total hot run time: 31236 ms |
TPC-DS: Total hot run time: 173099 ms |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
1. Add type checking in `Field::get()` 2. Use DecimalV2Value as ColumnItemType of TYPE_DECIMALV2
### What problem does this PR solve? pick #59488 #59669 #59733 #59831 ### Check List (For Author) - Test <!-- At least one of them must be included. --> - [ ] Regression test - [ ] Unit Test - [ ] Manual test (add detailed scripts or steps below) - [ ] No need to test or manual test. Explain why: - [ ] This is a refactor/code format and no logic has been changed. - [ ] Previous test can cover this change. - [ ] No code files have been changed. - [ ] Other reason <!-- Add your reason? --> - Behavior changed: - [ ] No. - [ ] Yes. <!-- Explain the behavior change --> - Does this need documentation? - [ ] No. - [ ] Yes. <!-- Add document PR link here. eg: apache/doris-website#1214 --> ### Check List (For Reviewer who merge this PR) - [ ] Confirm the release note - [ ] Confirm test cases - [ ] Confirm document - [ ] Add branch pick label <!-- Add branch pick label that this PR should merge into -->
What problem does this PR solve?
Field::get()Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)