Skip to content

branch-4.0: [fix](profile) sort out parquet reader profile (#58895) #59789

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
yiguolei merged 1 commit into from
Jan 13, 2026
Merged

branch-4.0: [fix](profile) sort out parquet reader profile (#58895) #59789

yiguolei merged 1 commit into from
Jan 13, 2026

Conversation

@morningman
Copy link
Contributor

@morningman morningman commented Jan 12, 2026

bp #58895

@morningman
[fix](profile) sort out parquet reader profile (apache#58895)
d4d1097 
Problem Summary:

Refine some metrics in parquet reader profile.
1. Rename some `Statistics` class name to make it readable. (There are
too many `Statistics` struct with same name)
2. Add `read page header timer` in parquet reader profile
3. fix issue of invalid check logic for `MergeRangeFileReader` when
setting prefetch buffer size
4. fix issue that data cache profile is incorrect for external table
can.
@morningman morningman requested a review from yiguolei as a code owner January 12, 2026 10:46
@Thearas
Copy link
Contributor

Thearas commented Jan 12, 2026

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@morningman
Copy link
Contributor Author

morningman commented Jan 12, 2026

run buildall

@doris-robot
Copy link

doris-robot commented Jan 12, 2026

BE UT Coverage Report

Increment line coverage 81.88% (122/149) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 53.42% (18803/35200)
Line Coverage 39.23% (174461/444722)
Region Coverage 33.95% (135065/397887)
Branch Coverage 34.87% (58305/167227)

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jan 13, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Jan 13, 2026

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 13, 2026

PR approved by anyone and no changes requested.

@yiguolei yiguolei merged commit 3940c79 into apache:branch-4.0 Jan 13, 2026
24 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yiguolei yiguolei yiguolei approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@morningman @Thearas @doris-robot @yiguolei