[feat](simplify range) Add more range inference simplifier rule. #59818
+270
−62
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
yujun777
force-pushed
the
fix-simplify-range-merge-compound-value-2
branch
from
a2839af to
72d4dea
Compare
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 32104 ms |
TPC-DS: Total hot run time: 172879 ms |
Contributor
FE Regression Coverage ReportIncrement line coverage |
yujun777
force-pushed
the
fix-simplify-range-merge-compound-value-2
branch
from
72d4dea to
492f6d9
Compare
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 31656 ms |
TPC-DS: Total hot run time: 172157 ms |
Contributor
FE UT Coverage ReportIncrement line coverage |
Contributor
FE Regression Coverage ReportIncrement line coverage |
Contributor
Author
|
run external |
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 31283 ms |
TPC-DS: Total hot run time: 173564 ms |
ClickBench: Total hot run time: 26.85 s |
Contributor
FE Regression Coverage ReportIncrement line coverage |
morrySnow
approved these changes
Jan 14, 2026
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
Contributor
Author
|
run external |
starocean999
approved these changes
Jan 15, 2026
yujun777
added a commit
to yujun777/doris
that referenced
this pull request
Jan 15, 2026
…che#59818) Add more inference rules: 1. simplify: `IsNull AND xx` ``` TA is null and TA > 10 => TA is null and null TA is null and TA = 10 => TA is null and null TA is null and TA != 10 => TA is null and null ``` then if this expression is in where condition, it will replace null to FALSE, and fold this expression to FALSE 2. simplify: `IsNotNull OR xx` ``` TA is not null or TA > 10 => TA is not null or null TA is not null or TA = 10 => TA is not null or null TA is not null or TA != 10 => TA is not null or null ``` then if this expression is in where condition, it will replace null to FALSE, and fold this expression to TA is not null 3. simplify: IsNotNull(TA) AND RangeAll(TA) = IsNotNull(TA) ``` TA is not null and (TA is not null or null) => TA is not null ``` 4. simplify: IsNull(TA) AND RangeAll(TA) = EmptyValue(TA) ``` TA is null and (TA is not null or null) = TA is null and null ``` 5. simplify: IsNotNull(TA) or EmptyValue(TA) = RangeAll(TA) ``` TA is not null or (TA is null and null) = TA is not null or null ``` 6. Fix merge compound value bug if `A AND B` is FALSE/EmptyValue, A AND (B OR C) = A AND C. but this has bug, if 'A AND B' is FALSE, the equation is correct. but if 'A AND B' is EmptyValue and A nullable, the equation maybe still wrong, for example: `a > 100 and (a = 1 or a is not null)`, it cann't simplify to `a > 100 and a is not null`. so we give up simplify this expression just in one step, if `A and B` is empty value, we replace B with EmptyValue, then we will have `A AND (B OR C)` = `A AND (EmptyValue OR C)`, then in the next expression rewrite iteration, it will try to simplify `EmptyValue OR C`. for the same logical for OR, then for 'A OR (B AND C)', if A OR B is RangeAll, then we replace B with RangeAll.
16 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add more inference rules:
IsNull AND xxthen if this expression is in where condition, it will replace null to FALSE, and fold this expression to FALSE
IsNotNull OR xxthen if this expression is in where condition, it will replace null to FALSE, and fold this expression to TA is not null
if
A AND Bis FALSE/EmptyValue, A AND (B OR C) = A AND C.but this has bug, if 'A AND B' is FALSE, the equation is correct.
but if 'A AND B' is EmptyValue and A nullable, the equation maybe still wrong, for example:
a > 100 and (a = 1 or a is not null), it cann't simplify toa > 100 and a is not null.so we give up simplify this expression just in one step, if
A and Bis empty value, we replace B with EmptyValue, then we will haveA AND (B OR C)=A AND (EmptyValue OR C), then in the next expression rewrite iteration, it will try to simplifyEmptyValue OR C.for the same logical for OR, then for 'A OR (B AND C)', if A OR B is RangeAll, then we replace B with RangeAll.
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)