-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[fix](parqeut)Fixed a performance fallback caused by filling RL DL when reading Parquet scalar columns. #59833
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
|
run buildall |
TPC-H: Total hot run time: 31757 ms |
TPC-DS: Total hot run time: 172742 ms |
|
run buildall |
TPC-H: Total hot run time: 31866 ms |
TPC-DS: Total hot run time: 173527 ms |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
…en reading Parquet scalar columns.
1473e5e to
770f06a
Compare
|
run buildall |
TPC-H: Total hot run time: 31771 ms |
TPC-DS: Total hot run time: 174300 ms |
ClickBench: Total hot run time: 27.1 s |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
kaka11chen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What problem does this PR solve?
Related PR: #58785
Problem Summary:
The performance rollback was introduced in #58785. The reason is that, prior to #58785, reading ordinary columns did not require filling and saving the RL DL. #58785 combined the logic for reading ordinary columns from a struct with the logic for reading ordinary columns, and filled and saved the RL DL to populate the null map information of the struct. This PR re-separates the reading logic.
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)