[fix] AggregationMethodOneNumber should handle ColumnNullable #8825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is a mistake to cast ColumnNullable* to ColumnVectorHelper*. UBSAN reports below messages: runtime error: member call on address 0x00002af70680 which does not point to a n object of type 'doris::vectorized::ColumnVectorHelper' The be core dump running tpcds q77 on 1T data set without UBSAN. Fix apache#8815.
dataroaring
added
dev/1.0.1-deprecated
morningman
removed
the
dev/1.0.1-deprecated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is a mistake to cast ColumnNullable* to ColumnVectorHelper*.
UBSAN reports below messages:
runtime error: member call on address 0x00002af70680 which does not point to a
n object of type 'doris::vectorized::ColumnVectorHelper'
The be core dump running tpcds q77 on 1T data set without UBSAN.
Fix #8815.
Proposed changes
Issue Number: close #8815
Problem Summary:
Describe the overview of changes.
Checklist(Required)
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...