DRILL-7734: Revise the result set reader #2077
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@paul-rogers, changes look good. Could you please resolve the checkstyle failure? |
Revised into two forms: push (for streaming JSON results) and pull (for one operator reading from another).
|
@vvysotskyi thanks for the review! Addressed checkstyle issue. Rebased on latest master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DRILL-7734: Revise the result set reader
Description
The "result set reader" uses the column accessors to iterate over rows from multiple batches, similar to how the "result set loader" creates batches in a scan. This PR refactors the code to clarify the two ways that the reader is used. First, the "pull" reader in one operator reads ("pulls") batches from an upstream operator. To implement JSON streaming, we need a second model, a "push" version where a caller provides batches.
Documentation
N/A
Testing
Added tests. Reran all unit tests.