DRILL-8451: options and profile pages have bad order symbols style #2820
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rymarm Would you mind please rebasing on current master? There's now a merge conflict as a result of your other PR. |
rymarm
force-pushed
the
DRILL-8451
branch
2 times, most recently
from
e384ba2 to
4d98e04
Compare
|
@cgivre Sure! Done. |
cgivre
pushed a commit
to cgivre/drill
that referenced
this pull request
Nov 2, 2023
jnturton
pushed a commit
that referenced
this pull request
Dec 31, 2023
jnturton
pushed a commit
to jnturton/drill
that referenced
this pull request
Dec 31, 2023
jnturton
pushed a commit
to jnturton/drill
that referenced
this pull request
Jan 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DRILL-8451: options and profile pages have bad order symbols style
Description
"Options" and "Profile" pages have bad order symbols style:
Current:
Expected:
"Options" and "Profile" pages were using Drill own sorting symbols styling instead of dataTables style that is used on all other pages. I've removed outdated
black-asc.gif,black-dsc.gif,black-unsorted.gifsorting symbols, and replaced them with dataTable styled symbols.I also disabled sorting for "value" and "description" columns on "Options" page. Sorting on "value" doesn't work properly due to different types of values, and sorting on the "description" column is just redundant.
Options page
before:
after:
Profile page
before:
after:
Documentation
None requerid
Testing
Visual check of UI in Firefox and Edge browsers.