DRILL-8446: Incorrect use of OperatingSystemMXBean #2843
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jnturton
added
bug
backport-to-stable
jnturton
force-pushed
the
8446-sun-mx-bean
branch
2 times, most recently
from
80f1c48 to
6f2966f
Compare
The com.sun.management internal implementation of OperatingSystemMXBean is used by Drill to report a CPU metric that is not available in the public interface. Even though code to handle non-Sun/Oracle runtimes for the OperatingSystemMXBean was present, it would still cause them to attempt to load a class from com.sun.management causing a NoClassDefFoundError.
jnturton
force-pushed
the
8446-sun-mx-bean
branch
from
6f2966f to
b4753d1
Compare
Hopefully. |
jnturton
added a commit
that referenced
this pull request
Dec 31, 2023
* Simplify CpuGaugeSet fixing the non-Sun/Oracle code path in the process. * Prevent flaky Splunk test from failing the CI test run.
jnturton
added a commit
to jnturton/drill
that referenced
this pull request
Dec 31, 2023
* Simplify CpuGaugeSet fixing the non-Sun/Oracle code path in the process. * Prevent flaky Splunk test from failing the CI test run.
jnturton
added a commit
to jnturton/drill
that referenced
this pull request
Dec 31, 2023
* Simplify CpuGaugeSet fixing the non-Sun/Oracle code path in the process. * Prevent flaky Splunk test from failing the CI test run.
jnturton
added a commit
to jnturton/drill
that referenced
this pull request
Jan 3, 2024
* Simplify CpuGaugeSet fixing the non-Sun/Oracle code path in the process. * Prevent flaky Splunk test from failing the CI test run.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DRILL-8446: Incorrect use of OperatingSystemMXBean
Description
Simplify CpuGaugeSet fixing the non-Sun/Oracle code path in the process.
The com.sun.management internal implementation of OperatingSystemMXBean is used by Drill to report a CPU metric that is not available in the public interface. Even though code to handle non-Sun/Oracle runtimes for the OperatingSystemMXBean was present, it would still cause them to attempt to load a class from com.sun.management causing a NoClassDefFoundError.
Documentation
N/A
Testing
Launch Drill and check the affected gauges in