Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DRILL-8485: HashJoinPOP memory leak is caused by an oom exception whe… #2891

Merged
merged 1 commit into from
Mar 25, 2024

Conversation

shfshihuafeng
Copy link
Contributor

@shfshihuafeng shfshihuafeng commented Mar 24, 2024

DRILL-8485: HashJoinPOP memory leak is caused by an oom exception when read data from InputStream

Description

it is similar to DRILL-8484

exception info

Caused by: org.apache.drill.exec.exception.OutOfMemoryException: Unable to allocate buffer of size 16384 (rounded from 15364) due to memory limit (41943040). Current allocation: 4337664
        at org.apache.drill.exec.memory.BaseAllocator.buffer(BaseAllocator.java:241)
        at org.apache.drill.exec.memory.BaseAllocator.buffer(BaseAllocator.java:216)
        at org.apache.drill.exec.memory.BaseAllocator.read(BaseAllocator.java:856)

leak info

  Allocator(frag:5:1) 5000000/1000000/27824128/40041943040 (res/actual/peak/limit)
      child allocators: 1
        Allocator(op:5:1:1:HashJoinPOP) 1000000/16384/22822912/41943040 (res/actual/peak/limit)
          child allocators: 0
          ledgers: 2
            ledger[442780] allocator: op:5:1:1:HashJoinPOP), isOwning: true, size: 8192, references: 2, life: 4486836603491..0, allocatorManager: [390894, life: 4486836601180..0] holds 4 buffers. 
                DrillBuf[458469], udle: [390895 1024..8192]
         event log for: DrillBuf[458469]

Documentation

(Please describe user-visible changes similar to what should appear in the Drill documentation.)

Testing

The testing method for drill-8485 is the similar as for DRILL-8484. we can throw exception in the method readVectors

Copy link
Contributor

@cgivre cgivre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM +1
Thanks @shfshihuafeng for all these memory leak fixes.

@cgivre cgivre added bug backport-to-stable This bug fix is applicable to the latest stable release and should be considered for inclusion there labels Mar 25, 2024
@cgivre cgivre merged commit 749772c into apache:master Mar 25, 2024
8 checks passed
@shfshihuafeng
Copy link
Contributor Author

shfshihuafeng commented Mar 25, 2024

LGTM +1 Thanks @shfshihuafeng for all these memory leak fixes.

Thank for your reviewed. I will do my best to continuously contribute to the community

jnturton pushed a commit to jnturton/drill that referenced this pull request Apr 12, 2024
jnturton pushed a commit that referenced this pull request Apr 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-to-stable This bug fix is applicable to the latest stable release and should be considered for inclusion there bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants