DRILL-8486: ParquetDecodingException: could not read bytes at offset #2898
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgivre
added
minor-update
backport-to-stable
jnturton
pushed a commit
to jnturton/drill
that referenced
this pull request
Apr 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DRILL-8486: fix handling of long variable length entries during bulk parquet reading
Description
Drill, during a bulk reading of a parquet file, unproperly handles a long value of parquet file entry. Drill reads the value, but after he finds that he can’t handle the value in the current batch, he just moves on, without persisting the read value. Since the value wasn’t pushed back to the reader object, the total read and left-to-read records counts are now in unproper state which causes data reading to fail in the future.
This issue hasn’t been faced before, because the conditions to get into this state are rare.
Solution
Push back the value to the reader object to read it in the next iteration, if the current batch can’t hold it.
Documentation
-
Testing
Manual testing with a parquet file from the Jira ticket: DRILL-8486. It's hard to reproduce this particular issue with random data.