using a helper method to bind to correct property path

apache · Dec 8, 2020 · 90dfa73 · 90dfa73
1 parent fae9a79
commit 90dfa73
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 2 deletions.
diff --git a/server/src/main/java/org/apache/druid/guice/StorageNodeModule.java b/server/src/main/java/org/apache/druid/guice/StorageNodeModule.java
@@ -55,7 +55,7 @@ public void configure(Binder binder)
   {
     JsonConfigProvider.bind(binder, "druid.server", DruidServerConfig.class);
     JsonConfigProvider.bind(binder, "druid.segmentCache", SegmentLoaderConfig.class);
-    JsonConfigProvider.bind(binder, "druid.segmentCache.locationSelector.strategy", StorageLocationSelectorStrategy.class);
+    bindLocationSelectorStrategy(binder);
 
     binder.bind(ServerTypeConfig.class).toProvider(Providers.of(null));
     binder.bind(ColumnConfig.class).to(DruidProcessingConfig.class);
@@ -132,4 +132,12 @@ public List<StorageLocation> provideStorageLocation(SegmentLoaderConfig config)
   {
     return config.toStorageLocations();
   }
+
+  /**
+   * a helper method for both storage module and independent unit test cases
+   */
+  public static void bindLocationSelectorStrategy(Binder binder)
+  {
+    JsonConfigProvider.bind(binder, "druid.segmentCache.locationSelector", StorageLocationSelectorStrategy.class);
+  }
 }
diff --git a/...r/src/test/java/org/apache/druid/segment/loading/StorageLocationSelectorStrategyTest.java b/...r/src/test/java/org/apache/druid/segment/loading/StorageLocationSelectorStrategyTest.java
@@ -29,6 +29,7 @@
 import org.apache.druid.guice.JsonConfigProvider;
 import org.apache.druid.guice.JsonConfigurator;
 import org.apache.druid.guice.LazySingleton;
+import org.apache.druid.guice.StorageNodeModule;
 import org.apache.druid.jackson.DefaultObjectMapper;
 import org.junit.Assert;
 import org.junit.Rule;
@@ -362,7 +363,7 @@ public void configure(Binder binder)
               binder.bind(Properties.class).toInstance(props);
 
               JsonConfigProvider.bind(binder, "druid.segmentCache", SegmentLoaderConfig.class);
-              JsonConfigProvider.bind(binder, "druid.segmentCache.locationSelector", StorageLocationSelectorStrategy.class);
+              StorageNodeModule.bindLocationSelectorStrategy(binder);
             }
 
             @Provides