Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check and make sure that the files that have been donated have been updated to reflect the new ASF copyright. #5835

Closed
drcrallen opened this issue May 31, 2018 · 3 comments
Assignees
Labels
Apache Items related to being a part of the ASF stale

Comments

@drcrallen
Copy link
Contributor

http://incubator.apache.org/projects/druid.html

@drcrallen drcrallen added the Apache Items related to being a part of the ASF label May 31, 2018
@drcrallen drcrallen self-assigned this May 31, 2018
@gianm
Copy link
Contributor

gianm commented Jul 11, 2018

#5976 updated almost all source files. There are a small number that were not updated: #5976 (comment). We can close this issue when those are figured out.

Files with a non-standard header (by Druid standards):

The license on the these three files seems ok (it's Apache 2.0) and also we already call this copying out in the NOTICE file. So they seem ok to me but I'm just calling them out to double-check.

We also have two files with no license header:

In that issue, @fjy said:

ConciseSetUtils is from the original ConciseSet library under the Apache license. The license header is missing for the file but it should be the same as the rest of the files under the ConciseSet library (Apache v2).

And:

IntList is from the same place

I can't find the original source of the Concise library. The paper is at https://arxiv.org/pdf/1004.0403.pdf, which links to source at http://concise.svn.sourceforge.net/viewvc/concise?view=rev&revision=1; however, that link is dead. However, I did some digging and found this commit: metamx/extendedset@02366f1#diff-97bd266eb5d2e8b0e7a38a658921356d. So it looks like these files with no headers were created in a refactor with code largely taken from ConciseSet (which is Apache licensed). So, that's good.

What's the best way to move forward here? Could we leave the first three files as-is, and add identical, nonstandard headers to the other two files describing where they came from and that they are Apache licensed?

@github-actions
Copy link

github-actions bot commented Jul 1, 2023

This issue has been marked as stale due to 280 days of inactivity.
It will be closed in 4 weeks if no further activity occurs. If this issue is still
relevant, please simply write any comment. Even if closed, you can still revive the
issue at any time or discuss it on the dev@druid.apache.org list.
Thank you for your contributions.

@github-actions github-actions bot added the stale label Jul 1, 2023
@github-actions
Copy link

This issue has been closed due to lack of activity. If you think that
is incorrect, or the issue requires additional review, you can revive the issue at
any time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Apache Items related to being a part of the ASF stale
Projects
None yet
Development

No branches or pull requests

2 participants