Skip to content

Conversation

@belugabehr
Copy link
Contributor

Fixes #XXXX.

Description

Fixed the bug ...

Renamed the class ...

Added a forbidden-apis entry ...


This PR has:

  • been self-reviewed.
  • added documentation for new or modified features or behaviors.
  • added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
  • added or updated version, license, or notice information in licenses.yaml
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
  • added integration tests.
  • been tested in a test Druid cluster.

Key changed/added classes in this PR
  • MyFoo
  • OurBar
  • TheirBaz

@belugabehr belugabehr closed this Dec 17, 2020
@belugabehr belugabehr reopened this Dec 17, 2020
@belugabehr
Copy link
Contributor Author

Failed to execute goal on project aliyun-oss-extensions: Could not resolve dependencies for project org.apache.druid.extensions.contrib:aliyun-oss-extensions:jar:0.21.0-SNAPSHOT: Failed to collect dependencies at com.aliyun.oss:aliyun-sdk-oss:jar:3.3.0 -> com.aliyun:aliyun-java-sdk-sts:jar:3.0.0: Failed to read artifact descriptor for com.aliyun:aliyun-java-sdk-sts:jar:3.0.0: Could not transfer artifact com.aliyun:aliyun-java-sdk-sts:pom:3.0.0 from/to central (https://repo.maven.apache.org/maven2): Failed to transfer file https://repo.maven.apache.org/maven2/com/aliyun/aliyun-java-sdk-sts/3.0.0/aliyun-java-sdk-sts-3.0.0.pom with status code 502

Seems like something is up with the build ENV

@belugabehr
Copy link
Contributor Author

Not sure how to proceed here. Things are failing because... SPOTBUGS for an issue I didn't add, not enough test coverage but I didn't add any new functionality, license failures, again, not sure how these changes did that.

@belugabehr
Copy link
Contributor Author

@asdf2014 Any thoughts on this?

}),
(AsyncFunction<Task, TaskStatus>) this::runTask
(AsyncFunction<Task, TaskStatus>) this::runTask,
Execs.directExecutor()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why it is Execs.directExecutor()?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wangyum
Because upgrading Guava requires an explicit Executor passed to the method. The previous behavior was to implicitly pass directExecutor if no Executor was provided. I tried to pass the guava version and some maven build tool plugin rejected the change and directed me to use this instead.

@jihoonson
Copy link
Contributor

Not sure how to proceed here. Things are failing because... SPOTBUGS for an issue I didn't add, not enough test coverage but I didn't add any new functionality, license failures, again, not sure how these changes did that.

Hi @belugabehr, we can ignore them if they are truly irrelevant, I haven't looked into details of Spotbugs or Intellij inspection failures though. However, I do see many real test failures in unit tests and integration tests which should be fixed before this PR gets merged. Also, the guava version is important to be compatible to other ecosystems and libraries such as Hadoop or AWS SDK. Integration tests for them are not running on Travis as they require additional setup such as AWS credentials, so you and the reviewers of this PR should run them manually before merge.

@stale
Copy link

stale bot commented Apr 29, 2022

This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 4 weeks if no further activity occurs. If you think that's incorrect or this pull request should instead be reviewed, please simply write any comment. Even if closed, you can still revive the PR at any time or discuss it on the dev@druid.apache.org list. Thank you for your contributions.

@stale stale bot added the stale label Apr 29, 2022
@github-actions
Copy link

github-actions bot commented Oct 5, 2023

This pull request/issue has been closed due to lack of activity. If you think that
is incorrect, or the pull request requires review, you can revive the PR at any time.

@github-actions github-actions bot closed this Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants