Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Web console: update dev dependencies #11119

Merged
merged 27 commits into from
Apr 17, 2021
Merged

Web console: update dev dependencies #11119

merged 27 commits into from
Apr 17, 2021

Conversation

jgoz
Copy link
Contributor

@jgoz jgoz commented Apr 15, 2021 •
edited
Loading

Description

This PR updates web-console dependency versions that are relatively safe and straightforward to upgrade. Some highlights:

  • TypeScript 4.2
  • Webpack 5
  • Jest 26
  • Prettier 2 (via awesome-code-style)

With the upgraded packages, npm install will now succeed on Node 14 without needing node-gyp.

And a couple of configuration changes:

  • Enable sourcemaps in development mode for nicer debugging in the browser
  • Set TypeScript module format to esnext to allow webpack to tree-shake

And finally, I removed some packages that were not being used.

This PR has:

  • been self-reviewed.
  • added documentation for new or modified features or behaviors.
  • added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
  • added or updated version, license, or notice information in licenses.yaml
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
  • added integration tests.
  • been tested in a test Druid cluster.

@lgtm-com
Copy link

lgtm-com bot commented Apr 15, 2021

This pull request fixes 1 alert when merging eca2e8d into cb7c6ac - view on LGTM.com

fixed alerts:

  • 1 for Syntax error

@vogievetsky
Copy link
Contributor

Thank you for the dependency updates, what a breath of fresh air!

The CI failure in the e2e tests looks legit:

image

@vogievetsky
Copy link
Contributor

also with all the dependency updates please make sure to run the script script/licenses from the web-console directory. It should update the root license listing with the new versions of the modules per Apache requirements.

@jgoz
Copy link
Contributor Author

jgoz commented Apr 16, 2021

@vogievetsky Thank you, I updated the licenses. It looks like tslib >= 1.11.2 is now licensed under 0BSD, which does not require inclusion of the copyright header. (Druid formerly used 1.10, which was Apache 2.0 licensed).

And I think the e2e test failure is due to Travis using a really old version of Node for that one step since it doesn't run through mvn. I'm not a Travis expert, but I attempted to ask it for Node 10 to match the rest of the pipeline. We'll see if he listens.

@lgtm-com
Copy link

lgtm-com bot commented Apr 16, 2021

This pull request fixes 1 alert when merging 0b41caf into 26d1074 - view on LGTM.com

fixed alerts:

  • 1 for Syntax error

@vogievetsky
Copy link
Contributor

image

Nice!

@lgtm-com
Copy link

lgtm-com bot commented Apr 16, 2021

This pull request fixes 1 alert when merging 443f2c5 into 26d1074 - view on LGTM.com

fixed alerts:

  • 1 for Syntax error

@lgtm-com
Copy link

lgtm-com bot commented Apr 16, 2021

This pull request fixes 1 alert when merging 722b02d into 26d1074 - view on LGTM.com

fixed alerts:

  • 1 for Syntax error

@lgtm-com
Copy link

lgtm-com bot commented Apr 16, 2021

This pull request fixes 1 alert when merging 0e91bcb into 26d1074 - view on LGTM.com

fixed alerts:

  • 1 for Syntax error

vogievetsky
vogievetsky approved these changes Apr 17, 2021
View reviewed changes
Copy link
Contributor

@vogievetsky vogievetsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@vogievetsky
Copy link
Contributor

image

...

image

Nice first contrib. good start, keep it up!

@vogievetsky vogievetsky merged commit fdc3c2f into apache:master Apr 17, 2021
@jgoz jgoz deleted the web-console-update-dependencies branch April 19, 2021 14:43
@clintropolis clintropolis added this to the 0.22.0 milestone Aug 12, 2021
jon-wei pushed a commit to jon-wei/druid that referenced this pull request Nov 22, 2021
@github-actions @techdocsmith
@suneet-s @gianm @isandeep41 @jgoz
Update from master-for-merge-to-release (apache#343)
3e456ac 
* Update security overview with additional recommendations (apache#11016)

* updatee security overview with additional recommendations for improved security

* address first set of review questions

* Update docs/operations/security-overview.md

* Update docs/operations/security-overview.md

* apply changes from review

* Update docs/operations/security-overview.md

Co-authored-by: Suneet Saldanha <suneet@apache.org>

* Update docs/operations/security-overview.md

Co-authored-by: Suneet Saldanha <suneet@apache.org>

* Update docs/operations/security-overview.md

Co-authored-by: Suneet Saldanha <suneet@apache.org>

* Update security-overview.md

fix additional comments & typos cc: @suneet-s, @jihoonsoon

Co-authored-by: Suneet Saldanha <suneet@apache.org>

* Enable rewriting certain inner joins as filters. (apache#11068)

* Enable rewriting certain inner joins as filters.

The main logic for doing the rewrite is in JoinableFactoryWrapper's
segmentMapFn method. The requirements are:

- It must be an inner equi-join.
- The right-hand columns referenced by the condition must not contain any
  duplicate values. (If they did, the inner join would not be guaranteed
  to return at most one row for each left-hand-side row.)
- No columns from the right-hand side can be used by anything other than
  the join condition itself.

HashJoinSegmentStorageAdapter is also modified to pass through to
the base adapter (even allowing vectorization!) in the case where 100%
of join clauses could be rewritten as filters.

In support of this goal:

- Add Query getRequiredColumns() method to help us figure out whether
  the right-hand side of a join datasource is being used or not.
- Add JoinConditionAnalysis getRequiredColumns() method to help us
  figure out if the right-hand side of a join is being used by later
  join clauses acting on the same base.
- Add Joinable getNonNullColumnValuesIfAllUnique method to enable
  retrieving the set of values that will form the "in" filter.
- Add LookupExtractor canGetKeySet() and keySet() methods to support
  LookupJoinable in its efforts to implement the new Joinable method.
- Add "enableRewriteJoinToFilter" feature flag to
  JoinFilterRewriteConfig. The default is disabled.

* Test improvements.

* Test fixes.

* Avoid slow size() call.

* Remove invalid test.

* Fix style.

* Fix mistaken default.

* Small fixes.

* Fix logic error.

* Doc updates for union datasources. (apache#11103)

The main one is updating datasources.md to talk about SQL. (It still said
that table unions are not supported in SQL.) Also, this doc update adds
some clarifying details on limitations.

* [Security] Bump netty4.version from 4.1.48.Final to 4.1.63.Final (apache#11117)

* Vectorized versions of HllSketch aggregators. (apache#11115)

* Vectorized versions of HllSketch aggregators.

The patch uses the same "helper" approach as apache#10767 and apache#10304, and
extends the tests to run in both vectorized and non-vectorized modes.

Also includes some minor changes to the theta sketch vector aggregator:

- Cosmetic changes to make the hll and theta implementations look
  more similar.
- Extends the theta SQL tests to run in vectorized mode.

* Updates post-code-review.

* Fix javadoc.

* Web console: update dev dependencies (apache#11119)

* Update some dev dependencies, prettify, tslint-fix

* Sort tsconfig keys for easy comparison

* Set noImplicitThis

* Slightly more accurate types

* Bump Jest and related

* Bump react to latest on v16

* Bump node-sass, sass-loader for node14 support

* Remove node-sass-chokidar (unused)

* More unused dependencies

* Fix blueprint imports

* Webpack 5

* Update webpack config for 'process' usage

* Update playwright-chromium

* Emit esnext modules for tree shaking

* Enable source maps in development

* Dedupe

* Bump babel and things

* npm audit fix

* Add .editorconfig file to match prettier settings

* Update licenses (tslib is 0BSD as of 1.11.2)

microsoft/tslib#96

* Require node >= 10

* Use Node 10 to run e2e tests

* Use 'ws' transport mode for dev server (will be default in next version)

* Remove an 'any'

* No sourcemaps in prod

* Exclude .editorconfig from license checks

* Try nvm for setting node version

Co-authored-by: Charles Smith <38529548+techdocsmith@users.noreply.github.com>
Co-authored-by: Suneet Saldanha <suneet@apache.org>
Co-authored-by: github-actions <github-actions@github.com>
Co-authored-by: Gian Merlino <gianmerlino@gmail.com>
Co-authored-by: Sandeep <isandeep41@gmail.com>
Co-authored-by: John Gozde <john@gozde.ca>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vogievetsky vogievetsky vogievetsky approved these changes

Assignees
No one assigned
Labels
Area - Dependencies Area - Web Console
Projects
None yet
Milestone
0.22.0
Development

Successfully merging this pull request may close these issues.
3 participants
@jgoz @vogievetsky @clintropolis