Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update kafka-ingestion.md to update PasswordProvider support limitation #11374

Merged
merged 1 commit into from
Jun 25, 2021
Merged

Update kafka-ingestion.md to update PasswordProvider support limitation #11374

merged 1 commit into from
Jun 25, 2021

Conversation

astrohsy
Copy link
Contributor

@astrohsy astrohsy commented Jun 21, 2021 •
edited
Loading

kafka-ingestion.md depicts that PasswordProvider is deprecated but is supported until the version of 0.20.0. However, according to the code below, PasswordProvider still works. I updated the Druid version in the note to help readers understand clearly.

druid/extensions-core/kafka-indexing-service/src/main/java/org/apache/druid/indexing/kafka/KafkaRecordSupplier.java

Lines 203 to 207 in ef006fd

PasswordProvider configPasswordProvider = configMapper.convertValue(
entry.getValue(),
PasswordProvider.class
);
properties.setProperty(propertyKey, configPasswordProvider.getPassword());

This PR has:

  • been self-reviewed.

clintropolis
clintropolis reviewed Jun 22, 2021
View reviewed changes
Copy link
Member

@clintropolis clintropolis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

docs/development/extensions-core/kafka-ingestion.md Outdated Show resolved Hide resolved
@astrohsy astrohsy changed the title Update kafka-ingestion.html to update PasswordProvider support limitation Update kafka-ingestion.md to update PasswordProvider support limitation Jun 23, 2021
@astrohsy
Copy link
Contributor Author

I squashed the two commits!

@jihoonson jihoonson merged commit ed0a57e into apache:master Jun 25, 2021
@jihoonson
Copy link
Contributor

@astrohsy thanks for the fix!

jihoonson pushed a commit to jihoonson/druid that referenced this pull request Jul 12, 2021
@astrohsy @clintropolis @jihoonson
Update kafka-ingestion.md to clarify PasswordProvider support limitat…
4075897 
…ion (apache#11374)

Co-authored-by: Clint Wylie <cjwylie@gmail.com>

Co-authored-by: Clint Wylie <cjwylie@gmail.com>
@clintropolis clintropolis added this to the 0.22.0 milestone Aug 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clintropolis clintropolis clintropolis left review comments

@jihoonson jihoonson jihoonson approved these changes

Assignees
No one assigned
Labels
Area - Documentation
Projects
None yet
Milestone
0.22.0
Development

Successfully merging this pull request may close these issues.
3 participants
@astrohsy @jihoonson @clintropolis