Use intermediate-persist IndexSpec during multiphase merge. #11940
Conversation
The main change is the addition of an intermediate-persist IndexSpec to the main "merge" method in IndexMerger. There are also a few minor adjustments to the IndexMerger interface to encourage more harmonious usage of its methods in the future.
|
This patch is getting nailed for test coverage in UnifiedIndexerAppenderatorsManager's LimitedPoolIndexMerger. In looking into this I've noticed that the class does need more tests, but also that a lot of IndexMerger interface methods are currently unused. Rather than add tests for all these unused methods, I'm looking into removing them. |
- Remove unused-in-production IndexMerger methods "append" and "convert". - Add additional unit tests to UnifiedIndexerAppenderatorsManager.
|
I pushed a change that removes the unused-in-production IndexMerger methods "append" and "convert", and adds additional unit tests to UnifiedIndexerAppenderatorsManager. Hopefully this will satisfy the coverage checker. |
|
The "analyze hadoop 3 dependencies" step keeps failing with this error: I'm not sure why that would be; maybe it's a caching thing on the Travis side? Restarting the test doesn't help. Is there a "super-restart"? |
I deleted all the Travis caches, maybe that'll do it. |
Looks like that helped! |
The main change is the addition of an intermediate-persist IndexSpec
to the main "merge" method in IndexMerger. There are also a few minor
adjustments to the IndexMerger interface to encourage more harmonious
usage of its methods in the future.