Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing metrics into statsd-reporter. #12762

Merged
merged 1 commit into from
Jul 9, 2022
Merged

Add missing metrics into statsd-reporter. #12762

merged 1 commit into from
Jul 9, 2022

Conversation

didip
Copy link
Contributor

@didip didip commented Jul 9, 2022

Description

StatsD metrics reporter is missing quite a number of metrics. This PR updates all the missing metrics.

Key changed/added classes in this PR
  • defaultMetricDimensions.json

This PR has:

  • been self-reviewed.
  • added documentation for new or modified features or behaviors.
  • added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
  • added or updated version, license, or notice information in licenses.yaml
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
  • added integration tests.
  • been tested in a test Druid cluster.

gianm
gianm approved these changes Jul 9, 2022
View reviewed changes
Copy link
Contributor

@gianm gianm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 thanks!

@didip
Copy link
Contributor Author

didip commented Jul 9, 2022

@gianm looks like everything is green. :)

@gianm gianm merged commit 48fd2e6 into apache:master Jul 9, 2022
@didip didip deleted the more-statsd-metrics branch July 9, 2022 14:24
@abhishekagarwal87 abhishekagarwal87 added this to the 24.0.0 milestone Aug 26, 2022
@techdocsmith techdocsmith mentioned this pull request Aug 26, 2022
Closed
@abhishekagarwal87 abhishekagarwal87 mentioned this pull request Sep 8, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gianm gianm gianm approved these changes

Assignees
No one assigned
Labels
Area - Metrics/Event Emitting
Projects
None yet
Milestone
24.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@didip @gianm @abhishekagarwal87