replaces hard-coded probe delays with helm values #12805
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jarnoux
force-pushed
the
helm-probe-delays
branch
from
c9f182a
to
ba20616
Compare
FrankChen021
added
the
Helm Chart
abhishekagarwal87
approved these changes
Jul 26, 2022
|
Thank you for your contribution @jarnoux |
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR lets helm users specify liveness and readiness probe delays for the historical StatefulSet. This is useful when historical pods take a long time loading segments during first run.
Hard-coded 60 second delay was replaced with a 60 seconds default value from
values.yamlThis PR has: