Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install bash-static in docker image #13063

Merged
merged 1 commit into from
Sep 9, 2022
Merged

Conversation

kfaraz
Copy link
Contributor

@kfaraz kfaraz commented Sep 9, 2022

Fixes issue #13057

This is a partial backport of #13059

With recent changes (addition of run-java script),
bash-static is required to run the docker container. Otherwise, ingestion fails with the following error.

middlemanager    | java.io.IOException: Cannot run program "bin/run-java": error=2, No such file or directory
middlemanager    |      at java.lang.ProcessBuilder.start(ProcessBuilder.java:1128) ~[?:?]
middlemanager    |      at java.lang.ProcessBuilder.start(ProcessBuilder.java:1071) ~[?:?]
middlemanager    |      at org.apache.druid.indexing.overlord.ForkingTaskRunner.runTaskProcess(ForkingTaskRunner.java:491) ~[druid-indexing-service-25.0.0-SNAPSHOT.jar:25.0.0-SNAPSHOT]
middlemanager    |      at org.apache.druid.indexing.overlord.ForkingTaskRunner$1.call(ForkingTaskRunner.java:390) ~[druid-indexing-service-25.0.0-SNAPSHOT.jar:25.0.0-SNAPSHOT]
middlemanager    |      at org.apache.druid.indexing.overlord.ForkingTaskRunner$1.call(ForkingTaskRunner.java:153) ~[druid-indexing-service-25.0.0-SNAPSHOT.jar:25.0.0-SNAPSHOT]
middlemanager    |      at java.util.concurrent.FutureTask.run(FutureTask.java:264) ~[?:?]
middlemanager    |      at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128) ~[?:?]
middlemanager    |      at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628) ~[?:?]
middlemanager    |      at java.lang.Thread.run(Thread.java:829) ~[?:?]
middlemanager    | Caused by: java.io.IOException: error=2, No such file or directory
middlemanager    |      at java.lang.ProcessImpl.forkAndExec(Native Method) ~[?:?]
middlemanager    |      at java.lang.ProcessImpl.<init>(ProcessImpl.java:340) ~[?:?]
middlemanager    |      at java.lang.ProcessImpl.start(ProcessImpl.java:271) ~[?:?]
middlemanager    |      at java.lang.ProcessBuilder.start(ProcessBuilder.java:1107) ~[?:?]

The other changes from PR #13059 are not being backported as they are potential improvements,
not bug-fixes and might pose some risk to the upcoming release.


This PR has:

  • been self-reviewed.
  • added documentation for new or modified features or behaviors.
  • added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
  • added or updated version, license, or notice information in licenses.yaml
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
  • added integration tests.
  • been tested in a test Druid cluster.

@kfaraz kfaraz added Docker https://hub.docker.com/r/apache/druid Backport labels Sep 9, 2022
@FrankChen021 FrankChen021 added this to the 24.0.0 milestone Sep 9, 2022
@vogievetsky vogievetsky merged commit 618098a into apache:24.0.0 Sep 9, 2022
@xvrl xvrl mentioned this pull request Sep 15, 2022
9 tasks
@kfaraz kfaraz deleted the fix_docker_run branch August 1, 2023 04:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backport Docker https://hub.docker.com/r/apache/druid
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants