Skip to content

Conversation

@FrankChen021
Copy link
Member

Fixes #12312 which was reported half a year ago.

This PR has:

  • been self-reviewed.
  • added documentation for new or modified features or behaviors.
  • added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
  • added or updated version, license, or notice information in licenses.yaml
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
  • added integration tests.
  • been tested in a test Druid cluster.

@gianm
Copy link
Contributor

gianm commented Sep 11, 2022

Couple questions:

@FrankChen021
Copy link
Member Author

Yes, we need it. The AllocationMetricCollector differs from the JvmMonitor that we changed before, and I have not found a management API to replace it.

  • Is it --add-exports or --add-opens that we need?

Basically, add-opens can be seen as a super set of add-exports. The former one allows us to access non-public methods via reflection while the latter one allows us to access public methods only. Use add-opens makes the things simpler.

Copy link
Contributor

@gianm gianm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ty, sounds good to me!

@gianm gianm merged commit eff7c64 into apache:master Sep 12, 2022
@FrankChen021 FrankChen021 deleted the run-java branch September 12, 2022 16:07
@kfaraz kfaraz added this to the 25.0 milestone Nov 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

jvm/heapAlloc/bytes not emitted when running Druid with JDK11+

3 participants