Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds a Jupyter visualization tutorial #13485

Closed
wants to merge 3 commits into from

Conversation

techdocsmith
Copy link
Contributor

This PR adds a Jupyter notebook illustrating basic table, bar, and line charts with Druid data.

This PR has:

  • been self-reviewed.

Copy link
Member

@vtlim vtlim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really cool tutorial! Left suggestions for improvement.

"\n",
"# Add the results to a pandas DataFrame.\n",
"editors_pd = pd.read_json(json.dumps(response.json()), orient='records')\n",
"editors_df = pd.DataFrame.from_records(editors_pd)\n",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should be able to use the editors_pd directly and remove this step

Copy link
Contributor

@317brian 317brian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM with some minor fixes needed

@@ -0,0 +1,159 @@
{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's this untitled file and the checkpoints folder in this PR

"metadata": {},
"source": [
"Set up values for your plots:\n",
"- Channels remains the basis for the x-axis.\n",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This list isn't parallel. The 3rd item starts w/ a verb

Copy link
Contributor

@317brian 317brian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 LGTM

Copy link
Member

@vtlim vtlim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🦖

@techdocsmith
Copy link
Contributor Author

@vtlim , updated this notebook to use the Druid API python library from #13787

@techdocsmith
Copy link
Contributor Author

plan to use the Kafka notebook as a template to get this one fixed & into the docs

@techdocsmith
Copy link
Contributor Author

The Jupyter notebook project has moved to https://github.com/implydata/learn-druid

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants