-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adds a Jupyter visualization tutorial #13485
Conversation
f7d9cdc
to
ae4ad43
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really cool tutorial! Left suggestions for improvement.
examples/quickstart/jupyter-notebooks/druid-visualization.ipynb
Outdated
Show resolved
Hide resolved
examples/quickstart/jupyter-notebooks/druid-visualization.ipynb
Outdated
Show resolved
Hide resolved
examples/quickstart/jupyter-notebooks/druid-visualization.ipynb
Outdated
Show resolved
Hide resolved
examples/quickstart/jupyter-notebooks/druid-visualization.ipynb
Outdated
Show resolved
Hide resolved
examples/quickstart/jupyter-notebooks/druid-visualization.ipynb
Outdated
Show resolved
Hide resolved
examples/quickstart/jupyter-notebooks/druid-visualization.ipynb
Outdated
Show resolved
Hide resolved
"\n", | ||
"# Add the results to a pandas DataFrame.\n", | ||
"editors_pd = pd.read_json(json.dumps(response.json()), orient='records')\n", | ||
"editors_df = pd.DataFrame.from_records(editors_pd)\n", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should be able to use the editors_pd
directly and remove this step
examples/quickstart/jupyter-notebooks/druid-visualization.ipynb
Outdated
Show resolved
Hide resolved
examples/quickstart/jupyter-notebooks/druid-visualization.ipynb
Outdated
Show resolved
Hide resolved
examples/quickstart/jupyter-notebooks/druid-visualization.ipynb
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly LGTM with some minor fixes needed
@@ -0,0 +1,159 @@ | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's this untitled file and the checkpoints folder in this PR
examples/quickstart/jupyter-notebooks/druid-visualization.ipynb
Outdated
Show resolved
Hide resolved
examples/quickstart/jupyter-notebooks/druid-visualization.ipynb
Outdated
Show resolved
Hide resolved
examples/quickstart/jupyter-notebooks/druid-visualization.ipynb
Outdated
Show resolved
Hide resolved
"metadata": {}, | ||
"source": [ | ||
"Set up values for your plots:\n", | ||
"- Channels remains the basis for the x-axis.\n", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This list isn't parallel. The 3rd item starts w/ a verb
examples/quickstart/jupyter-notebooks/druid-visualization.ipynb
Outdated
Show resolved
Hide resolved
examples/quickstart/jupyter-notebooks/druid-visualization.ipynb
Outdated
Show resolved
Hide resolved
examples/quickstart/jupyter-notebooks/druid-visualization.ipynb
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀 LGTM
examples/quickstart/jupyter-notebooks/druid-visualization.ipynb
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🦖
plan to use the Kafka notebook as a template to get this one fixed & into the docs |
175be51
to
4769dda
Compare
b3254e0
to
3a5d3d9
Compare
The Jupyter notebook project has moved to https://github.com/implydata/learn-druid |
This PR adds a Jupyter notebook illustrating basic table, bar, and line charts with Druid data.
This PR has: