Fix behaviour of downsampling buckets to a single key #13663
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
While downsampling, we exclude buckets which contain only a single key. However, there is an issue where if a bucket is downsampled to a single key (which is contained as the min value in a DelegateOrMinCollector), and if the same bucket is still the largest bucket that remains to be downsampled, the collector continues trying to downsample the same bucket infinitely. This adds a check to prevent this condition.
This PR has: