-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more statement attributes to explain plan result. #14391
Merged
kfaraz
merged 19 commits into
apache:master
from
abhishekrb19:explain_plan_explicit_attributes
Jun 12, 2023
Merged
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
a98e2f3
Add more sql attributes to explain plan's attribute column.
abhishekrb19 36bc6a3
java docs.
abhishekrb19 1a82f2a
readme update
abhishekrb19 5836980
fixup test
abhishekrb19 0986b46
backticks, fix the static check
abhishekrb19 5c40f91
Merge branch 'master' into explain_plan_explicit_attributes
abhishekrb19 230c188
UT fixes
abhishekrb19 e6c86d7
more UT fixes.
abhishekrb19 60915b6
Add REPLACE query example to illustrate the different non-null attrib…
abhishekrb19 af4f9ce
Adjust example.
abhishekrb19 0f4d22d
Update docs/querying/sql-translation.md
abhishekrb19 4c3d193
Update docs/querying/sql-translation.md
abhishekrb19 d04ee61
Update sql/src/main/java/org/apache/druid/sql/calcite/planner/Explain…
abhishekrb19 67d5406
Code review comments; Include non-null annotation for getters.
abhishekrb19 0393f32
Merge branch 'explain_plan_explicit_attributes' of github.com:abhishe…
abhishekrb19 9e96b2b
doc updates.
abhishekrb19 f5d6958
typo
abhishekrb19 40310c4
fixup test
abhishekrb19 3c38d11
Add ExplainAttributesTest
abhishekrb19 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it work to have this annotation just once at the class level instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, it seems like we do a mix of method-level and class-level annotations in the codebase. Since we already do
@Nullable
consistently for all the methods in this class, I just stuck with the former.