Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce coordinator logs when operating normally #14926

Merged
merged 1 commit into from
Aug 30, 2023
Merged

Reduce coordinator logs when operating normally #14926

merged 1 commit into from
Aug 30, 2023

Conversation

kfaraz
Copy link
Contributor

@kfaraz kfaraz commented Aug 30, 2023 •
edited
Loading

Changes

  • Reduce log level of some coordinator stats, which only denote normal coordinator operation. These stats are still emitted and can be logged by setting debugDimensions in the coordinator dynamic config.
  • Initialize SegmentLoadingConfig only for historical management duties. This config is not needed in other duties and initializing it creates logs which are misleading.

This PR has:

  • been self-reviewed.
  • added documentation for new or modified features or behaviors.
  • a release note entry in the PR description.
  • added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
  • added or updated version, license, or notice information in licenses.yaml
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
  • added integration tests.
  • been tested in a test Druid cluster.

@kfaraz kfaraz merged commit 8263f0d into apache:master Aug 30, 2023
74 checks passed
@kfaraz kfaraz deleted the reduce_coordinator_logs branch August 30, 2023 06:00
@kfaraz
Copy link
Contributor Author

kfaraz commented Aug 30, 2023

Thanks for the review, @clintropolis !

jakubmatyszewski pushed a commit to jakubmatyszewski/druid that referenced this pull request Sep 8, 2023
@kfaraz @jakubmatyszewski
Reduce coordinator logs when operating normally (apache#14926)
0aa6770 
Changes:
- Reduce log level of some coordinator stats, which only denote normal coordinator operation.
These stats are still emitted and can be logged by setting debugDimensions in the coordinator
dynamic config.
- Initialize SegmentLoadingConfig only for historical management duties. This config is not
needed in other duties and initializing it creates logs which are misleading.
@LakshSingla LakshSingla added this to the 28.0 milestone Oct 12, 2023
@LakshSingla LakshSingla mentioned this pull request Nov 4, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clintropolis clintropolis clintropolis approved these changes

Assignees
No one assigned
Labels
Area - Segment Balancing/Coordination
Projects
None yet
Milestone
28.0
Development

Successfully merging this pull request may close these issues.
3 participants
@kfaraz @clintropolis @LakshSingla